<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111210/">http://git.reviewboard.kde.org/r/111210/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The kxmlgui_unittest crash is due to more Q_D/Q_DECLARE_PRIVATE usage in kxmlguiwindow. Fixed with http://pastebin.kde.org/794456/
Next step, the failure in ktoolbar_unittest...</pre>
<br />
<p>- David</p>
<br />
<p>On July 10th, 2013, 6:44 p.m. UTC, Andrea Scarpino wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Andrea Scarpino.</div>
<p style="color: grey;"><i>Updated July 10, 2013, 6:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move:
* KAboutApplicationDialog
* KBugReport
* KHelpMenu
* KShortcutsEditor
* KShortcutsDialog
* KEditToolBar
* KShortcutWidget
* KKeySequenceWidget
* KXmlGuiClient
* KXmlGuiFactory
* KXmlGuiBuilder
* KMainWindow
* KToolBar
* KActionCollection
* KToggleBarAction
* KActionCategory
to XmlGui.
This also move the FindLibAttica module in xmlgui/.
Notes:
* the code that uses KGestureMap has been commented. What to do?
* the code that uses KGlobalSettings has been commented. Waiting for a decision to be taken in the thread http://lists.kde.org/?l=kde-frameworks-devel&m=137149104802300&w=2</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds.
* autotests/ktoolbar_unittest, 1 failed, core dumped
* autotests/kxmlgui_unittest, 35 failed, core dumped
* tests/kwindowtest segfaults
* tests/kxmlguiwindowtest segfaults
* autotests/kglobalshortcuttest, 5 failed</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d7c5260)</span></li>
<li>cmake/modules/CMakeLists.txt <span style="color: grey">(4602cd7)</span></li>
<li>cmake/modules/FindLibAttica.cmake <span style="color: grey">(e758a5a)</span></li>
<li>kdeui/CMakeLists.txt <span style="color: grey">(35b4019)</span></li>
<li>kdeui/TODO.xmlgui <span style="color: grey">()</span></li>
<li>kdeui/actions/kactioncategory.h <span style="color: grey">(25f3be8)</span></li>
<li>kdeui/actions/kactioncategory.cpp <span style="color: grey">()</span></li>
<li>kdeui/actions/kactioncollection.h <span style="color: grey">(aa6603a)</span></li>
<li>kdeui/actions/kactioncollection.cpp <span style="color: grey">(fc4e067)</span></li>
<li>kdeui/actions/ktoggletoolbaraction.h <span style="color: grey">(e937ba3)</span></li>
<li>kdeui/actions/ktoggletoolbaraction.cpp <span style="color: grey">(5db4192)</span></li>
<li>kdeui/dialogs/kaboutapplicationconfigattica_p.h.cmake <span style="color: grey">()</span></li>
<li>kdeui/dialogs/kaboutapplicationdialog.h <span style="color: grey">(7459f7e)</span></li>
<li>kdeui/dialogs/kaboutapplicationdialog.cpp <span style="color: grey">(d656fa2)</span></li>
<li>kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.h <span style="color: grey">()</span></li>
<li>kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.cpp <span style="color: grey">(8933202)</span></li>
<li>kdeui/dialogs/kaboutapplicationpersonlistview_p.h <span style="color: grey">()</span></li>
<li>kdeui/dialogs/kaboutapplicationpersonlistview_p.cpp <span style="color: grey">()</span></li>
<li>kdeui/dialogs/kaboutapplicationpersonmodel_p.h <span style="color: grey">(5001da8)</span></li>
<li>kdeui/dialogs/kaboutapplicationpersonmodel_p.cpp <span style="color: grey">(25d2765)</span></li>
<li>kdeui/dialogs/kaboutkdedialog_p.h <span style="color: grey">()</span></li>
<li>kdeui/dialogs/kaboutkdedialog_p.cpp <span style="color: grey">(35061f6)</span></li>
<li>kdeui/dialogs/kbugreport.h <span style="color: grey">(c3ace5e)</span></li>
<li>kdeui/dialogs/kbugreport.cpp <span style="color: grey">(cf56aa3)</span></li>
<li>kdeui/dialogs/kedittoolbar.h <span style="color: grey">(217c3c6)</span></li>
<li>kdeui/dialogs/kedittoolbar.cpp <span style="color: grey">(b4fb8cb)</span></li>
<li>kdeui/dialogs/kedittoolbar_p.h <span style="color: grey">(c6436d2)</span></li>
<li>kdeui/dialogs/kshortcuteditwidget.cpp <span style="color: grey">(228a401)</span></li>
<li>kdeui/dialogs/kshortcutschemeseditor.cpp <span style="color: grey">(095aeeb)</span></li>
<li>kdeui/dialogs/kshortcutsdialog.h <span style="color: grey">(54082f9)</span></li>
<li>kdeui/dialogs/kshortcutsdialog.cpp <span style="color: grey">(1a187b3)</span></li>
<li>kdeui/dialogs/kshortcutsdialog.ui <span style="color: grey">()</span></li>
<li>kdeui/dialogs/kshortcutsdialog_p.h <span style="color: grey">(78067fa)</span></li>
<li>kdeui/dialogs/kshortcutseditor.h <span style="color: grey">(5b7e24a)</span></li>
<li>kdeui/dialogs/kshortcutseditor.cpp <span style="color: grey">(5fad58b)</span></li>
<li>kdeui/dialogs/kshortcutseditordelegate.cpp <span style="color: grey">(53c619c)</span></li>
<li>kdeui/dialogs/kshortcutseditoritem.cpp <span style="color: grey">(3be65ef)</span></li>
<li>kdeui/dialogs/kswitchlanguagedialog_p.h <span style="color: grey">()</span></li>
<li>kdeui/dialogs/kswitchlanguagedialog_p.cpp <span style="color: grey">(466d8dc)</span></li>
<li>kdeui/kdepackages.h <span style="color: grey">()</span></li>
<li>kdeui/make_kdepackages_updated.py <span style="color: grey">()</span></li>
<li>kdeui/shortcuts/kshortcutschemeshelper.cpp <span style="color: grey">(1ea1631)</span></li>
<li>kdeui/shortcuts/kshortcutschemeshelper_p.h <span style="color: grey">()</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(b6d5b30)</span></li>
<li>kdeui/tests/kactioncategorytest.h <span style="color: grey">()</span></li>
<li>kdeui/tests/kactioncategorytest.cpp <span style="color: grey">()</span></li>
<li>kdeui/tests/kbugreporttest.cpp <span style="color: grey">(cd71173)</span></li>
<li>kdeui/tests/kmainwindow_unittest.h <span style="color: grey">()</span></li>
<li>kdeui/tests/kmainwindow_unittest.cpp <span style="color: grey">()</span></li>
<li>kdeui/tests/kmainwindowrestoretest.h <span style="color: grey">()</span></li>
<li>kdeui/tests/kmainwindowrestoretest.cpp <span style="color: grey">(95146a2)</span></li>
<li>kdeui/tests/kmainwindowtest.h <span style="color: grey">()</span></li>
<li>kdeui/tests/kmainwindowtest.cpp <span style="color: grey">(3deac97)</span></li>
<li>kdeui/tests/ktoolbar_unittest.cpp <span style="color: grey">(4e1431b)</span></li>
<li>kdeui/tests/ktoolbartest.cpp <span style="color: grey">(25c0598)</span></li>
<li>kdeui/tests/kwindowtest.h <span style="color: grey">(24c344a)</span></li>
<li>kdeui/tests/kwindowtest.cpp <span style="color: grey">(4217f65)</span></li>
<li>kdeui/tests/kwindowtest.rc <span style="color: grey">()</span></li>
<li>kdeui/tests/kxmlgui_unittest.h <span style="color: grey">()</span></li>
<li>kdeui/tests/kxmlgui_unittest.cpp <span style="color: grey">(cf99a0a)</span></li>
<li>kdeui/tests/kxmlguitest.h <span style="color: grey">()</span></li>
<li>kdeui/tests/kxmlguitest.cpp <span style="color: grey">(cc8d9d3)</span></li>
<li>kdeui/tests/kxmlguitest_part.rc <span style="color: grey">()</span></li>
<li>kdeui/tests/kxmlguitest_shell.rc <span style="color: grey">()</span></li>
<li>kdeui/tests/kxmlguiwindowtest.cpp <span style="color: grey">(ac484e2)</span></li>
<li>kdeui/tests/kxmlguiwindowtestui.rc <span style="color: grey">()</span></li>
<li>kdeui/tests/testguiclient.h <span style="color: grey">(f10207e)</span></li>
<li>kdeui/tests/testxmlguiwindow.h <span style="color: grey">(0ac78fe)</span></li>
<li>kdeui/widgets/khelpmenu.h <span style="color: grey">(9210810)</span></li>
<li>kdeui/widgets/khelpmenu.cpp <span style="color: grey">(24e44db)</span></li>
<li>kdeui/widgets/kkeysequencewidget.h <span style="color: grey">(6ea1b5a)</span></li>
<li>kdeui/widgets/kkeysequencewidget.cpp <span style="color: grey">(235353f)</span></li>
<li>kdeui/widgets/kkeysequencewidget_p.h <span style="color: grey">()</span></li>
<li>kdeui/widgets/kshortcutwidget.h <span style="color: grey">(18ec960)</span></li>
<li>kdeui/widgets/kshortcutwidget.cpp <span style="color: grey">()</span></li>
<li>kdeui/widgets/kshortcutwidget.ui <span style="color: grey">()</span></li>
<li>kdeui/xmlgui/kmainwindow.h <span style="color: grey">(32e37cf)</span></li>
<li>kdeui/xmlgui/kmainwindow.cpp <span style="color: grey">(e7f2d31)</span></li>
<li>kdeui/xmlgui/kmainwindow_p.h <span style="color: grey">(92646f3)</span></li>
<li>kdeui/xmlgui/kmainwindowiface.cpp <span style="color: grey">(6c77d93)</span></li>
<li>kdeui/xmlgui/kmainwindowiface_p.h <span style="color: grey">(b59b2b1)</span></li>
<li>kdeui/xmlgui/kmenumenuhandler_p.h <span style="color: grey">()</span></li>
<li>kdeui/xmlgui/kmenumenuhandler_p.cpp <span style="color: grey">(27cd5c3)</span></li>
<li>kdeui/xmlgui/kpartgui.dtd <span style="color: grey">()</span></li>
<li>kdeui/xmlgui/ktoolbar.h <span style="color: grey">(94f5c81)</span></li>
<li>kdeui/xmlgui/ktoolbar.cpp <span style="color: grey">(8157bb4)</span></li>
<li>kdeui/xmlgui/ktoolbarhandler.cpp <span style="color: grey">(1ad8da6)</span></li>
<li>kdeui/xmlgui/ktoolbarhandler_p.h <span style="color: grey">()</span></li>
<li>kdeui/xmlgui/kxmlgui.xsd <span style="color: grey">()</span></li>
<li>kdeui/xmlgui/kxmlguibuilder.h <span style="color: grey">(e841384)</span></li>
<li>kdeui/xmlgui/kxmlguibuilder.cpp <span style="color: grey">(04d760c)</span></li>
<li>kdeui/xmlgui/kxmlguiclient.h <span style="color: grey">(3b06b50)</span></li>
<li>kdeui/xmlgui/kxmlguiclient.cpp <span style="color: grey">(96ea35b)</span></li>
<li>kdeui/xmlgui/kxmlguifactory.h <span style="color: grey">(c6e853b)</span></li>
<li>kdeui/xmlgui/kxmlguifactory.cpp <span style="color: grey">(272b010)</span></li>
<li>kdeui/xmlgui/kxmlguifactory_p.h <span style="color: grey">()</span></li>
<li>kdeui/xmlgui/kxmlguifactory_p.cpp <span style="color: grey">(42b97d4)</span></li>
<li>kdeui/xmlgui/kxmlguiversionhandler.cpp <span style="color: grey">(3e6227b)</span></li>
<li>kdeui/xmlgui/kxmlguiversionhandler_p.h <span style="color: grey">()</span></li>
<li>kdeui/xmlgui/kxmlguiwindow.h <span style="color: grey">(218cd77)</span></li>
<li>kdeui/xmlgui/kxmlguiwindow.cpp <span style="color: grey">(a74eece)</span></li>
<li>kdeui/xmlgui/ui_standards.rc <span style="color: grey">()</span></li>
<li>staging/xmlgui/CMakeLists.txt <span style="color: grey">(6320a19)</span></li>
<li>staging/xmlgui/autotests/CMakeLists.txt <span style="color: grey">(83c2b11)</span></li>
<li>staging/xmlgui/cmake/FindLibAttica.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/xmlgui/src/CMakeLists.txt <span style="color: grey">(7eb71f4)</span></li>
<li>staging/xmlgui/src/config-xmlgui.h.cmake <span style="color: grey">(58949d8)</span></li>
<li>staging/xmlgui/src/kglobalaccel.h <span style="color: grey">(cfa30ae)</span></li>
<li>staging/xmlgui/src/kglobalaccel.cpp <span style="color: grey">(2d71d8a)</span></li>
<li>staging/xmlgui/tests/CMakeLists.txt <span style="color: grey">(dce637f)</span></li>
<li>staging/xmlgui/tests/ktoolbartest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/xmlgui/tests/kxmlguitest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111210/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>