<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111493/">http://git.reviewboard.kde.org/r/111493/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks ok.
Beside that, the same comments as for kservice.
Thanks a lot :-)</pre>
<br />
<p>- Alexander</p>
<br />
<p>On July 12th, 2013, 1:19 p.m. UTC, Benjamin Port wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Benjamin Port.</div>
<p style="color: grey;"><i>Updated July 12, 2013, 1:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In order to have all frameworks using the same name policy (i.e. use CamelCase for libraries names) rename kwidgets framework lib to KWidgets</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/kimproxy/library/CMakeLists.txt <span style="color: grey">(5bc4b4d)</span></li>
<li>interfaces/kmediaplayer/kfileaudiopreview/CMakeLists.txt <span style="color: grey">(fa83d78)</span></li>
<li>kdeui/CMakeLists.txt <span style="color: grey">(3ca2e13)</span></li>
<li>kdewidgets/CMakeLists.txt <span style="color: grey">(1f72c6f)</span></li>
<li>kfile/CMakeLists.txt <span style="color: grey">(765266c)</span></li>
<li>kio/CMakeLists.txt <span style="color: grey">(c5cc280)</span></li>
<li>kio/kssl/kcm/CMakeLists.txt <span style="color: grey">(fa75e53)</span></li>
<li>kio/tests/CMakeLists.txt <span style="color: grey">(a0d7e88)</span></li>
<li>kioslave/http/kcookiejar/CMakeLists.txt <span style="color: grey">(533068f)</span></li>
<li>knewstuff/knewstuff3/CMakeLists.txt <span style="color: grey">(4118ea7)</span></li>
<li>knotify/config/CMakeLists.txt <span style="color: grey">(db7c8d7)</span></li>
<li>knotify/tests/CMakeLists.txt <span style="color: grey">(57e2a2d)</span></li>
<li>kparts/CMakeLists.txt <span style="color: grey">(da398e9)</span></li>
<li>kutils/CMakeLists.txt <span style="color: grey">(60da2ac)</span></li>
<li>staging/kcompletion/src/CMakeLists.txt <span style="color: grey">(b125459)</span></li>
<li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(96ba1ad)</span></li>
<li>staging/kemoticons/src/core/CMakeLists.txt <span style="color: grey">(1e375a7)</span></li>
<li>staging/kiconthemes/src/CMakeLists.txt <span style="color: grey">(3cb795c)</span></li>
<li>staging/kinterprocesswindowing/src/CMakeLists.txt <span style="color: grey">(1c18f57)</span></li>
<li>staging/ktextwidgets/src/CMakeLists.txt <span style="color: grey">(6b3c09f)</span></li>
<li>staging/kwidgets/CMakeLists.txt <span style="color: grey">(3dd1fe3)</span></li>
<li>staging/kwidgets/KWidgetsConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kwidgets/kwidgetsConfig.cmake.in <span style="color: grey">(bf761ac)</span></li>
<li>staging/kwidgets/src/CMakeLists.txt <span style="color: grey">(9ae3c2e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111493/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>