<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111456/">http://git.reviewboard.kde.org/r/111456/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">thanks!</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111456/diff/3/?file=170248#file170248line78" style="color: black; font-weight: bold; text-decoration: underline;">staging/kcrash/src/kcrash.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">76</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// Copy from klauncer_cmds</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">klauncer -> klauncher</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111456/diff/3/?file=170254#file170254line24" style="color: black; font-weight: bold; text-decoration: underline;">staging/kcrash/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">24</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">remove_definitions</span><span class="p">(</span><span class="s">-DQT_NO_KEYWORDS</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">not set anymore -> you can remove this line</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On July 10th, 2013, 7:02 p.m. UTC, Benjamin Port wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Benjamin Port.</div>
<p style="color: grey;"><i>Updated July 10, 2013, 7:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Create KCrash framework
Copy/Paste struct from klauncher_cmds to kcrash and rename it to avoid conflict</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kded/CMakeLists.txt <span style="color: grey">(6283135)</span></li>
<li>kdeui/CMakeLists.txt <span style="color: grey">(35b4019)</span></li>
<li>kdeui/util/config-strlcpy.h.cmake <span style="color: grey">()</span></li>
<li>kdeui/util/kcrash.h <span style="color: grey">(f0c92f8)</span></li>
<li>kdeui/util/kcrash.cpp <span style="color: grey">(2e36c03)</span></li>
<li>kdeui/util/strlcpy-fake.c <span style="color: grey">(e75cae3)</span></li>
<li>kinit/CMakeLists.txt <span style="color: grey">(52c132c)</span></li>
<li>kinit/kinit.cpp <span style="color: grey">(d95f3a4)</span></li>
<li>kio/CMakeLists.txt <span style="color: grey">(812bbaa)</span></li>
<li>staging/CMakeLists.txt <span style="color: grey">(3832396)</span></li>
<li>staging/kcrash/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kcrash/KCrashConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kcrash/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kcrash/src/config-kcrash.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/autotests/CMakeLists.txt <span style="color: grey">(d179a1c)</span></li>
<li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(8b2cd5b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111456/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>