<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111453/">http://git.reviewboard.kde.org/r/111453/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111453/diff/1/?file=169485#file169485line29" style="color: black; font-weight: bold; text-decoration: underline;">tier1/kwidgetsaddons/src/kacceleratormanager_p.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">28</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <QTabBar></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A forward declaration "class QTabBar;" is enough here, same for qmenubar and qdockwidget.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111453/diff/1/?file=169486#file169486line81" style="color: black; font-weight: bold; text-decoration: underline;">staging/kwidgets/src/actions/kstandardaction.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KWIDGETS_EXPORT KStandardShortcut::StandardShortcut shortcutForActionId(StandardAction id)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">81</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KAcceleratorManagerPrivate</span><span class="o">::</span><span class="n">appendStandardNames</span><span class="p">(</span><span class="n">kaccmp_sns</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The QStringList pointer is not great. How about this instead?
KAcceleratorManagerPrivate::setStandardActionNames(stdNames());
With a function-local static bool so that this is done only once.
Even better would be to export a single function in a namespace, rather than exporting the whole class KAcceleratorManagerPrivate.
Note that kaccmp_sns can go away completely then.</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On July 8th, 2013, 4:39 p.m. UTC, Wojciech Kapuscinski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Wojciech Kapuscinski.</div>
<p style="color: grey;"><i>Updated July 8, 2013, 4:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">move kacceleratormanager to KWidgetAddons.
Note:
This is only for review because this patch contains some ugly hack (export symbol from private class) and this patch is only Proof-on-concept.
Changes:
rename kacceleratormanager_private.h -> kacceleratormanager_p.h
move KAcceleratorManagerPrivate class definition from kacceleratormanager.cpp to kacceleratormanager_p.h
set translated texts when KStandardAction is constructed for the firs time.
Open questions:
- should I add static method for example initStandardNames in KAcceleratorManager namespace that replace appendStandarNames and remove export symbol from KAcceleratorManagerPrivate ?
- use QMutex in KAcceleratorManager that guarantees thread-safety (lock/unlock mutex in standardNames and initStandardNames)?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(35b4019)</span></li>
<li>kdeui/shortcuts/kacceleratormanager.h <span style="color: grey">(68e87d2)</span></li>
<li>kdeui/shortcuts/kacceleratormanager.cpp <span style="color: grey">(990b093)</span></li>
<li>kdeui/shortcuts/kacceleratormanager_private.h <span style="color: grey">(ab04d42)</span></li>
<li>staging/kwidgets/src/actions/kstandardaction.cpp <span style="color: grey">(0c3733a)</span></li>
<li>tier1/kwidgetsaddons/src/CMakeLists.txt <span style="color: grey">(82d42db)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111453/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>