<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111453/">http://git.reviewboard.kde.org/r/111453/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Wojciech Kapuscinski.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">move kacceleratormanager to KWidgetAddons.
Note:
This is only for review because this patch contains some ugly hack (export symbol from private class) and this patch is only Proof-on-concept.
Changes:
rename kacceleratormanager_private.h -> kacceleratormanager_p.h
move KAcceleratorManagerPrivate class definition from kacceleratormanager.cpp to kacceleratormanager_p.h
set translated texts when KStandardAction is constructed for the firs time.
Open questions:
- should I add static method for example initStandardNames in KAcceleratorManager namespace that replace appendStandarNames and remove export symbol from KAcceleratorManagerPrivate ?
- use QMutex in KAcceleratorManager that guarantees thread-safety (lock/unlock mutex in standardNames and initStandardNames)?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(35b4019)</span></li>
<li>kdeui/shortcuts/kacceleratormanager.h <span style="color: grey">(68e87d2)</span></li>
<li>kdeui/shortcuts/kacceleratormanager.cpp <span style="color: grey">(990b093)</span></li>
<li>kdeui/shortcuts/kacceleratormanager_private.h <span style="color: grey">(ab04d42)</span></li>
<li>staging/kwidgets/src/actions/kstandardaction.cpp <span style="color: grey">(0c3733a)</span></li>
<li>tier1/kwidgetsaddons/src/CMakeLists.txt <span style="color: grey">(82d42db)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111453/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>