<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111409/">http://git.reviewboard.kde.org/r/111409/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Finally my patch in Qt seems that will get to the dev branch soon, so let's start using it.
- Move the code from KGlobalSettings to the KDE platform theme to handle fonts properly.
- Port uses of KGlobalSettings::*Fonts to newer alternatives.
- Drop some MacOS switches regarding the fonts. It doesn't make sense since on MacOS we'll be running the MacOS QPA.
NOTE: KGlobalSettings::menuFont, toolBarFont and taskBarFont have some weird workaround that I'm unsure how to fix. Maybe I should instantiate one of them?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/dialogs/kaboutapplicationdialog.cpp <span style="color: grey">(d656fa2)</span></li>
<li>kdeui/dialogs/kshortcutseditor.cpp <span style="color: grey">(5fad58b)</span></li>
<li>kdeui/fonts/kfontcombobox.cpp <span style="color: grey">(7097ec3)</span></li>
<li>kdeui/util/kglobalsettings.cpp <span style="color: grey">(5aad31f)</span></li>
<li>khtml/css/cssstyleselector.cpp <span style="color: grey">(b5eb370)</span></li>
<li>khtml/khtml_settings.cpp <span style="color: grey">(5ed0aeb)</span></li>
<li>khtml/rendering/render_replaced.cpp <span style="color: grey">(7872838)</span></li>
<li>khtml/xml/dom_docimpl.cpp <span style="color: grey">(f30b244)</span></li>
<li>kio/kfile/kpropertiesdialog.cpp <span style="color: grey">(850a509)</span></li>
<li>kio/kssl/ksslcertdialog.cpp <span style="color: grey">(65301a6)</span></li>
<li>staging/frameworkintegration/src/platformtheme/CMakeLists.txt <span style="color: grey">(8cc5614)</span></li>
<li>staging/frameworkintegration/src/platformtheme/kdeplatformtheme.h <span style="color: grey">(4bd1eae)</span></li>
<li>staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp <span style="color: grey">(fba7d13)</span></li>
<li>staging/frameworkintegration/src/platformtheme/kglobalsettingsdata.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/frameworkintegration/src/platformtheme/kglobalsettingsdata.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4attic/src/kcupsoptionsjobwidget_p.cpp <span style="color: grey">(15771ec)</span></li>
<li>staging/kde4attic/src/kdatepicker.cpp <span style="color: grey">(8006e31)</span></li>
<li>staging/kde4attic/src/kdatetable.cpp <span style="color: grey">(6f1832f)</span></li>
<li>tier1/kwidgetsaddons/src/kfontchooser.cpp <span style="color: grey">(53a4a90)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111409/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>