<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110858/">http://git.reviewboard.kde.org/r/110858/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Vadim Zhukov.</div>
<p style="color: grey;"><i>Updated July 5, 2013, 3:01 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Even more fixes, including things like that:
- list_entries=`wc -l $remove_list | grep -o "[0-9][0-9]\?[0-9]\?[0-9]\?[0-9]\? " | grep -o "[0-9][0-9]\?[0-9]\?[0-9]\?[0-9]\?"`
+ list_entries=`wc -l < "$remove_list"`</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Many KDE development scripts were written in a hurry and are:
* unportable, e.g.: using bash instead of sh
* unreliable, e.g.: using of $* instead of $@ in shell scripts
* unsecure, e.g.: using open($file) idiom in Perl scripts
I tweaked most obvious stuff that I found. This patch allows to better integrate KDE development process into OpenBSD ecosystem, and, probably, in ecosystem of other OSes. Not saying about getting more reliable results for non-usual cases, such as filenames with non-ASCII-alphanum-characters in them.
Given that KDE5 is coming, I think it's a good time to improve some core stuff. :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Light tested on OpenBSD-CURRENT, from KDE 4.10.1 till 4.10.4. As I'm not a KDE developer, this definitely needs more precise look.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>adddebug <span style="color: grey">(782db52)</span></li>
<li>astyle-kdelibs <span style="color: grey">(0450e8a)</span></li>
<li>build-progress.sh <span style="color: grey">(64247fc)</span></li>
<li>cheatmake <span style="color: grey">(9659a6c)</span></li>
<li>colorsvn <span style="color: grey">(84dec6b)</span></li>
<li>cvsaddcurrentdir <span style="color: grey">(503c7f3)</span></li>
<li>cvsblame <span style="color: grey">(bd3635e)</span></li>
<li>cvslastlog <span style="color: grey">(d1b4581)</span></li>
<li>draw_lib_dependencies <span style="color: grey">(1db6ef6)</span></li>
<li>kf5/functionUtilkde.pm <span style="color: grey">(79b6547)</span></li>
<li>makeobj <span style="color: grey">(4c9cca8)</span></li>
<li>nonsvnlist <span style="color: grey">(f94c3e8)</span></li>
<li>optimizegraphics <span style="color: grey">(c5f79b2)</span></li>
<li>package_crystalsvg <span style="color: grey">(1502da2)</span></li>
<li>qt4/adapt-kconfiggroupsaver.pl <span style="color: grey">(ccd0e4e)</span></li>
<li>qt4/adapt-to-kde4-api.pl <span style="color: grey">(8364ef4)</span></li>
<li>qt4/adapt-to-new-kconfig2.pl <span style="color: grey">(b0e660f)</span></li>
<li>qt4/adapt-to-new-kdebug-api.pl <span style="color: grey">(cf96261)</span></li>
<li>qt4/adapt-to-qt4-api.pl <span style="color: grey">(c225c62)</span></li>
<li>qt4/convert-bad-qdatastream.pl <span style="color: grey">(779b0a0)</span></li>
<li>qt4/convert-display.pl <span style="color: grey">(2c971b6)</span></li>
<li>qt4/convert-find-to-indexof.pl <span style="color: grey">(f732684)</span></li>
<li>qt4/convert-kgenericfactory.pl <span style="color: grey">(f8355bd)</span></li>
<li>qt4/convert-killtimers.pl <span style="color: grey">(60be59e)</span></li>
<li>qt4/convert-kinstance.pl <span style="color: grey">(ca3d590)</span></li>
<li>qt4/convert-kkeydialog.pl <span style="color: grey">(f5581b4)</span></li>
<li>qt4/convert-kmimetype-pixmap.pl <span style="color: grey">(003c9fb)</span></li>
<li>qt4/convert-kstringhandler.pl <span style="color: grey">(0b42bc5)</span></li>
<li>qt4/convert-newq4headers.pl <span style="color: grey">(57c5148)</span></li>
<li>qt4/convert-q3cstring.pl <span style="color: grey">(a6a1919)</span></li>
<li>qt4/convert-qboxlayout.pl <span style="color: grey">(564e197)</span></li>
<li>qt4/convert-qgridlayout.pl <span style="color: grey">(367dca0)</span></li>
<li>qt4/convert-qiodevice_at.pl <span style="color: grey">(ff1ae8f)</span></li>
<li>qt4/convert-qlabel.pl <span style="color: grey">(4f0f3c4)</span></li>
<li>qt4/convert-qstringlatin1.pl <span style="color: grey">(76f3de6)</span></li>
<li>qt4/convert-qvhbox.pl <span style="color: grey">(7ab1afa)</span></li>
<li>qt4/convert-signal.pl <span style="color: grey">(be50e9d)</span></li>
<li>qt4/fix-link.pl <span style="color: grey">(34ae20b)</span></li>
<li>qt4/functionUtilkde.pm <span style="color: grey">(79b6547)</span></li>
<li>qt4/icons-kde3tokde4-renamer/icons-kde3to4-renamer.sh <span style="color: grey">(97cecd1)</span></li>
<li>qt4/remove-qt3-support.pl <span style="color: grey">(0e34b8a)</span></li>
<li>qt4/replaceAddRowSpacing.sh <span style="color: grey">(a86087f)</span></li>
<li>qt4/replaceRenamedDeprecated.sh <span style="color: grey">(fa7cd06)</span></li>
<li>qt4/search-qstringlist.sh <span style="color: grey">(2601441)</span></li>
<li>qt4/search-qwhatsthis.sh <span style="color: grey">(a34857c)</span></li>
<li>qt4/search-registeredApplications.sh <span style="color: grey">(31911ba)</span></li>
<li>svn-clean <span style="color: grey">(3c698bd)</span></li>
<li>svn2log.sh <span style="color: grey">(ef78f56)</span></li>
<li>svnaddcurrentdir <span style="color: grey">(53eb384)</span></li>
<li>svnforwardport <span style="color: grey">(f8dd9d6)</span></li>
<li>svnversions <span style="color: grey">(fbdca03)</span></li>
<li>unsercmake <span style="color: grey">(24170ab)</span></li>
<li>wcgrep <span style="color: grey">(477bab5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110858/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>