<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111210/">http://git.reviewboard.kde.org/r/111210/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Impressive piece of work, well done.
The commit log is a bit confusing. KHelpMenu is really a small piece of the puzzle. This in fact most of the XMLGUI technology to the xmlgui framework, including KToolBar and KMainWindow.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111210/diff/3/?file=167431#file167431line310" style="color: black; font-weight: bold; text-decoration: underline;">staging/xmlgui/src/kaboutapplicationdialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KAboutApplicationDialog::Private::_k_showLicense( const QString &number )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">308</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#if 0</span><span class="c"></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">please add a
#pragma message("Use QFontDatabase::systemFont(QFontDatabase::FixedFont) once https://codereview.qt-project.org/59808 is in")
(so you can also clarify that part of the message log - the final decision is clear now)</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111210/diff/3/?file=167437#file167437line317" style="color: black; font-weight: bold; text-decoration: underline;">staging/xmlgui/src/kaboutapplicationpersonmodel_p.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString KAboutApplicationPersonProfileOcsLink::prettyType() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">316</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="s">"Delicious"</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">315</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n"><span class="hl">QString</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">QLatin1String</span></span><span class="p"><span class="hl">(</span></span><span class="s">"Delicious"</span><span class="p"><span class="hl">))</span>;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's quite verbose. QLatin1String("Delicious") or better QStringLiteral("Delicious") would be enough. The conversion to QString will happen implicitly since that's the return type of the method.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111210/diff/3/?file=167464#file167464line31" style="color: black; font-weight: bold; text-decoration: underline;">staging/xmlgui/tests/kbugreporttest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">31</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KAboutData</span> <span class="n">about</span><span class="p">(</span><span class="s"><span class="hl">"kbugreporttest"</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="mi"><span class="hl">0</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">i18n</span></span><span class="p">(</span><span class="s">"kbugreporttest"</span><span class="p">),</span> <span class="s"><span class="hl">"version"</span></span><span class="p"><span class="hl">);</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">31</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KAboutData</span> <span class="n">about</span><span class="p">(</span><span class="n"><span class="hl">QLatin1String</span></span><span class="p">(</span><span class="s">"kbugreporttest"</span><span class="p">),</span> <span class="n"><span class="hl">QLatin1String</span></span><span class="p"><span class="hl">(</span></span><span class="mi"><span class="hl">0</span></span><span class="p"><span class="hl">),</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QLatin1String(0) hurts my eyes. Please make it just QString().
</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111210/diff/3/?file=167471#file167471line477" style="color: black; font-weight: bold; text-decoration: underline;">staging/xmlgui/autotests/ktoolbar_unittest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void tst_KToolBar::changeGlobalToolButtonStyleSetting(const QString& mainToolBar, const QString& otherToolBars)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">466</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QMetaObject</span><span class="o">::</span><span class="n">invokeMethod</span><span class="p">(</span><span class="n">KGlobalSettings</span><span class="o">::</span><span class="n">self</span><span class="p">(),</span> <span class="s">"_k_slotNotifyChange"</span><span class="p">,</span> <span class="n">Q_ARG</span><span class="p">(</span><span class="kt">int</span><span class="p">,</span> <span class="n">KGlobalSettings</span><span class="o">::</span><span class="n">ToolbarStyleChanged</span><span class="p">),</span> <span class="n">Q_ARG</span><span class="p">(</span><span class="kt">int</span><span class="p">,</span> <span class="mi">0</span><span class="p">));</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">473</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"> QMetaObject::invokeMethod(KGlobalSettings::self(), "_k_slotNotifyChange", Q_ARG(int, KGlobalSettings::ToolbarStyleChanged), Q_ARG(int, 0));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">strange test indeed... we notify of the change, but don't check anything afterwards. Weird.
Let's leave it for now, then.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111210/diff/3/?file=167492#file167492line548" style="color: black; font-weight: bold; text-decoration: underline;">staging/xmlgui/src/kmainwindow.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KMainWindow::readGlobalProperties( KConfig* )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">541</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span><span class="o">!</span><span class="n">cg</span><span class="p">.</span><span class="n">hasDefault</span><span class="p">(</span><span class="s">"StatusBar"</span><span class="p">)</span> <span class="o">&&</span> <span class="o">!</span><span class="n">sb</span><span class="o">-></span><span class="n">isHidden</span><span class="p">()</span> <span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">545</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span><span class="o">!</span><span class="n">cg</span><span class="p">.</span><span class="n">hasDefault</span><span class="p">(</span><span class="s">"StatusBar"</span><span class="p">)</span> <span class="o">&&</span> <span class="o">!</span><span class="n">sb</span><span class="o">-></span><span class="n">isHidden</span><span class="p">()</span> <span class="p">)</span><span class="hl"> </span><span class="n"><span class="hl">cg</span></span><span class="p"><span class="hl">.</span></span><span class="n"><span class="hl">revertToDefault</span></span><span class="p"><span class="hl">(</span></span><span class="s"><span class="hl">"StatusBar"</span></span><span class="p"><span class="hl">);</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">something strange happened here. A newline got removed?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111210/diff/3/?file=167503#file167503line162" style="color: black; font-weight: bold; text-decoration: underline;">staging/xmlgui/src/kxmlguibuilder.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QWidget *KXMLGUIBuilder::createContainer( QWidget *parent, int index, const QDomElement &element, QAction*& containerAction )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">159</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QByteArray</span> <span class="n">name</span> <span class="o">=</span> <span class="n">element</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span> <span class="n">d</span><span class="o">-></span><span class="n">attrName</span> <span class="p">).</span><span class="n">toUtf8</span><span class="p">();</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">161</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QByteArray</span> <span class="n">name</span> <span class="o">=</span> <span class="n">element</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span> <span class="n">d</span><span class="o">-></span><span class="n">attrName</span> <span class="p">).</span><span class="n">toUtf8</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ok, if every use of "name" below is to convert it back to QString, why not change the type of this variable to a QString and remove the toUtf8() ?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111210/diff/3/?file=167505#file167505line143" style="color: black; font-weight: bold; text-decoration: underline;">staging/xmlgui/src/kxmlguiclient.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KXMLGUIClient::~KXMLGUIClient()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">140</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">actionCollection</span><span class="p">()</span><span class="o">-></span><span class="n">action</span><span class="p">(</span> <span class="n">qPrintable</span><span class="p">(</span><span class="n">element</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span><span class="s">"name"</span><span class="p">)</span> <span class="p">))</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">140</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">actionCollection</span><span class="p">()</span><span class="o">-></span><span class="n">action</span><span class="p">(</span> <span class="n"><span class="hl">QLatin1String</span></span><span class="p"><span class="hl">(</span></span><span class="n">qPrintable</span><span class="p">(</span><span class="n">element</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span><span class="s">"name"</span><span class="p">)</span> <span class="p">))<span class="hl">)</span></span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">qPrintable converts QString to char*.
QLatin1String converts char* to QString.
It's like matter and anti-matter :-)
Please remove both.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111210/diff/3/?file=167505#file167505line709" style="color: black; font-weight: bold; text-decoration: underline;">staging/xmlgui/src/kxmlguiclient.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KXMLGUIClient::stateChanged(const QString &newstate, KXMLGUIClient::ReverseStateChange reverse)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">705</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QAction</span> <span class="o">*</span><span class="n">action</span> <span class="o">=</span> <span class="n">actionCollection</span><span class="p">()</span><span class="o">-></span><span class="n">action</span><span class="p">(</span><span class="n">qPrintable</span><span class="p">((</span><span class="o">*</span><span class="n">it</span><span class="p">)));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">706</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QAction</span> <span class="o">*</span><span class="n">action</span> <span class="o">=</span> <span class="n">actionCollection</span><span class="p">()</span><span class="o">-></span><span class="n">action</span><span class="p">(</span><span class="n"><span class="hl">QLatin1String</span></span><span class="p"><span class="hl">(</span></span><span class="n">qPrintable</span><span class="p">((</span><span class="o">*</span><span class="n">it</span><span class="p">)))<span class="hl">)</span>;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">same here</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111210/diff/3/?file=167505#file167505line718" style="color: black; font-weight: bold; text-decoration: underline;">staging/xmlgui/src/kxmlguiclient.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KXMLGUIClient::stateChanged(const QString &newstate, KXMLGUIClient::ReverseStateChange reverse)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">714</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QAction</span> <span class="o">*</span><span class="n">action</span> <span class="o">=</span> <span class="n">actionCollection</span><span class="p">()</span><span class="o">-></span><span class="n">action</span><span class="p">(</span><span class="n">qPrintable</span><span class="p">((</span><span class="o">*</span><span class="n">it</span><span class="p">)));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">715</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QAction</span> <span class="o">*</span><span class="n">action</span> <span class="o">=</span> <span class="n">actionCollection</span><span class="p">()</span><span class="o">-></span><span class="n">action</span><span class="p">(</span><span class="n"><span class="hl">QLatin1String</span></span><span class="p"><span class="hl">(</span></span><span class="n">qPrintable</span><span class="p">((</span><span class="o">*</span><span class="n">it</span><span class="p">)))<span class="hl">)</span>;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">same here</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111210/diff/3/?file=167516#file167516line105" style="color: black; font-weight: bold; text-decoration: underline;">staging/xmlgui/src/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">105</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">SonnetUi</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sonnet? I'm surprised. What's the relation between kmainwindow/kxmlgui* and sonnet?</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On July 2nd, 2013, 4:31 p.m. UTC, Andrea Scarpino wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Andrea Scarpino.</div>
<p style="color: grey;"><i>Updated July 2, 2013, 4:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move:
* KAboutApplicationDialog
* KBugReport
* KHelpMenu
* KShortcutsEditor
* KShortcutsDialog
* KEditToolBar
* KShortcutWidget
* KKeySequenceWidget
* KXmlGuiClient
* KXmlGuiFactory
* KXmlGuiBuilder
* KMainWindow
* KToolBar
* KActionCollection
* KToggleBarAction
* KActionCategory
to XmlGui.
Notes:
* the code that uses KGestureMap has been commented. What to do?
* the code that uses KGlobalSettings has been commented. Waiting for a decision to be taken in the thread http://lists.kde.org/?l=kde-frameworks-devel&m=137149104802300&w=2
Needs both:
* https://git.reviewboard.kde.org/r/111183/
* https://git.reviewboard.kde.org/r/111191/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds.
Several {auto,}tests segfaults.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(d8b9b53)</span></li>
<li>kdeui/actions/kactioncategory.h <span style="color: grey">(25f3be8)</span></li>
<li>kdeui/actions/kactioncategory.cpp <span style="color: grey">()</span></li>
<li>kdeui/actions/kactioncollection.h <span style="color: grey">(8ca6845)</span></li>
<li>kdeui/actions/kactioncollection.cpp <span style="color: grey">(7dc2987)</span></li>
<li>kdeui/actions/ktoggletoolbaraction.h <span style="color: grey">(e937ba3)</span></li>
<li>kdeui/actions/ktoggletoolbaraction.cpp <span style="color: grey">(5db4192)</span></li>
<li>kdeui/dialogs/kaboutapplicationconfigattica_p.h.cmake <span style="color: grey">()</span></li>
<li>kdeui/dialogs/kaboutapplicationdialog.h <span style="color: grey">(7459f7e)</span></li>
<li>kdeui/dialogs/kaboutapplicationdialog.cpp <span style="color: grey">(d656fa2)</span></li>
<li>kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.h <span style="color: grey">()</span></li>
<li>kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.cpp <span style="color: grey">(8933202)</span></li>
<li>kdeui/dialogs/kaboutapplicationpersonlistview_p.h <span style="color: grey">()</span></li>
<li>kdeui/dialogs/kaboutapplicationpersonlistview_p.cpp <span style="color: grey">()</span></li>
<li>kdeui/dialogs/kaboutapplicationpersonmodel_p.h <span style="color: grey">(5001da8)</span></li>
<li>kdeui/dialogs/kaboutapplicationpersonmodel_p.cpp <span style="color: grey">(25d2765)</span></li>
<li>kdeui/dialogs/kaboutkdedialog_p.h <span style="color: grey">()</span></li>
<li>kdeui/dialogs/kaboutkdedialog_p.cpp <span style="color: grey">(35061f6)</span></li>
<li>kdeui/dialogs/kbugreport.h <span style="color: grey">(c3ace5e)</span></li>
<li>kdeui/dialogs/kbugreport.cpp <span style="color: grey">(cf56aa3)</span></li>
<li>kdeui/dialogs/kedittoolbar.h <span style="color: grey">(217c3c6)</span></li>
<li>kdeui/dialogs/kedittoolbar.cpp <span style="color: grey">(b4fb8cb)</span></li>
<li>kdeui/dialogs/kedittoolbar_p.h <span style="color: grey">(c6436d2)</span></li>
<li>kdeui/dialogs/kshortcuteditwidget.cpp <span style="color: grey">(228a401)</span></li>
<li>kdeui/dialogs/kshortcutschemeseditor.cpp <span style="color: grey">(095aeeb)</span></li>
<li>kdeui/dialogs/kshortcutsdialog.h <span style="color: grey">(54082f9)</span></li>
<li>kdeui/dialogs/kshortcutsdialog.cpp <span style="color: grey">(1a187b3)</span></li>
<li>kdeui/dialogs/kshortcutsdialog.ui <span style="color: grey">()</span></li>
<li>kdeui/dialogs/kshortcutsdialog_p.h <span style="color: grey">(78067fa)</span></li>
<li>kdeui/dialogs/kshortcutseditor.h <span style="color: grey">(5b7e24a)</span></li>
<li>kdeui/dialogs/kshortcutseditor.cpp <span style="color: grey">(5fad58b)</span></li>
<li>kdeui/dialogs/kshortcutseditordelegate.cpp <span style="color: grey">(53c619c)</span></li>
<li>kdeui/dialogs/kshortcutseditoritem.cpp <span style="color: grey">(3be65ef)</span></li>
<li>kdeui/dialogs/kswitchlanguagedialog_p.h <span style="color: grey">()</span></li>
<li>kdeui/dialogs/kswitchlanguagedialog_p.cpp <span style="color: grey">(466d8dc)</span></li>
<li>kdeui/kdepackages.h <span style="color: grey">()</span></li>
<li>kdeui/make_kdepackages_updated.py <span style="color: grey">()</span></li>
<li>kdeui/shortcuts/kshortcutschemeshelper.cpp <span style="color: grey">(1ea1631)</span></li>
<li>kdeui/shortcuts/kshortcutschemeshelper_p.h <span style="color: grey">()</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(6ef234a)</span></li>
<li>kdeui/tests/kactioncategorytest.h <span style="color: grey">()</span></li>
<li>kdeui/tests/kactioncategorytest.cpp <span style="color: grey">()</span></li>
<li>kdeui/tests/kbugreporttest.cpp <span style="color: grey">(cd71173)</span></li>
<li>kdeui/tests/kmainwindow_unittest.h <span style="color: grey">()</span></li>
<li>kdeui/tests/kmainwindow_unittest.cpp <span style="color: grey">()</span></li>
<li>kdeui/tests/kmainwindowrestoretest.h <span style="color: grey">()</span></li>
<li>kdeui/tests/kmainwindowrestoretest.cpp <span style="color: grey">(95146a2)</span></li>
<li>kdeui/tests/kmainwindowtest.h <span style="color: grey">()</span></li>
<li>kdeui/tests/kmainwindowtest.cpp <span style="color: grey">(3deac97)</span></li>
<li>kdeui/tests/ktoolbar_unittest.cpp <span style="color: grey">(4e1431b)</span></li>
<li>kdeui/tests/ktoolbartest.cpp <span style="color: grey">(25c0598)</span></li>
<li>kdeui/tests/kxmlgui_unittest.h <span style="color: grey">()</span></li>
<li>kdeui/tests/kxmlgui_unittest.cpp <span style="color: grey">(cf99a0a)</span></li>
<li>kdeui/tests/kxmlguitest.h <span style="color: grey">()</span></li>
<li>kdeui/tests/kxmlguitest.cpp <span style="color: grey">(cc8d9d3)</span></li>
<li>kdeui/tests/kxmlguitest_part.rc <span style="color: grey">()</span></li>
<li>kdeui/tests/kxmlguitest_shell.rc <span style="color: grey">()</span></li>
<li>kdeui/tests/kxmlguiwindowtest.cpp <span style="color: grey">(ac484e2)</span></li>
<li>kdeui/tests/kxmlguiwindowtestui.rc <span style="color: grey">()</span></li>
<li>kdeui/tests/testguiclient.h <span style="color: grey">(f10207e)</span></li>
<li>kdeui/tests/testxmlguiwindow.h <span style="color: grey">(0ac78fe)</span></li>
<li>kdeui/widgets/khelpmenu.h <span style="color: grey">(9210810)</span></li>
<li>kdeui/widgets/khelpmenu.cpp <span style="color: grey">(24e44db)</span></li>
<li>kdeui/widgets/kkeysequencewidget.h <span style="color: grey">(6ea1b5a)</span></li>
<li>kdeui/widgets/kkeysequencewidget.cpp <span style="color: grey">(235353f)</span></li>
<li>kdeui/widgets/kkeysequencewidget_p.h <span style="color: grey">()</span></li>
<li>kdeui/widgets/kshortcutwidget.h <span style="color: grey">(18ec960)</span></li>
<li>kdeui/widgets/kshortcutwidget.cpp <span style="color: grey">()</span></li>
<li>kdeui/widgets/kshortcutwidget.ui <span style="color: grey">()</span></li>
<li>kdeui/xmlgui/kmainwindow.h <span style="color: grey">(32e37cf)</span></li>
<li>kdeui/xmlgui/kmainwindow.cpp <span style="color: grey">(e7f2d31)</span></li>
<li>kdeui/xmlgui/kmainwindow_p.h <span style="color: grey">(92646f3)</span></li>
<li>kdeui/xmlgui/kmainwindowiface.cpp <span style="color: grey">(6c77d93)</span></li>
<li>kdeui/xmlgui/kmainwindowiface_p.h <span style="color: grey">(b59b2b1)</span></li>
<li>kdeui/xmlgui/kmenumenuhandler_p.h <span style="color: grey">()</span></li>
<li>kdeui/xmlgui/kmenumenuhandler_p.cpp <span style="color: grey">(27cd5c3)</span></li>
<li>kdeui/xmlgui/ktoolbar.h <span style="color: grey">(94f5c81)</span></li>
<li>kdeui/xmlgui/ktoolbar.cpp <span style="color: grey">(8157bb4)</span></li>
<li>kdeui/xmlgui/ktoolbarhandler.cpp <span style="color: grey">(1ad8da6)</span></li>
<li>kdeui/xmlgui/ktoolbarhandler_p.h <span style="color: grey">()</span></li>
<li>kdeui/xmlgui/kxmlguibuilder.h <span style="color: grey">(e841384)</span></li>
<li>kdeui/xmlgui/kxmlguibuilder.cpp <span style="color: grey">(04d760c)</span></li>
<li>kdeui/xmlgui/kxmlguiclient.h <span style="color: grey">(3b06b50)</span></li>
<li>kdeui/xmlgui/kxmlguiclient.cpp <span style="color: grey">(96ea35b)</span></li>
<li>kdeui/xmlgui/kxmlguifactory.h <span style="color: grey">(c6e853b)</span></li>
<li>kdeui/xmlgui/kxmlguifactory.cpp <span style="color: grey">(272b010)</span></li>
<li>kdeui/xmlgui/kxmlguifactory_p.h <span style="color: grey">()</span></li>
<li>kdeui/xmlgui/kxmlguifactory_p.cpp <span style="color: grey">(42b97d4)</span></li>
<li>kdeui/xmlgui/kxmlguiversionhandler.cpp <span style="color: grey">(3e6227b)</span></li>
<li>kdeui/xmlgui/kxmlguiversionhandler_p.h <span style="color: grey">()</span></li>
<li>kdeui/xmlgui/kxmlguiwindow.h <span style="color: grey">(218cd77)</span></li>
<li>kdeui/xmlgui/kxmlguiwindow.cpp <span style="color: grey">(a74eece)</span></li>
<li>staging/xmlgui/CMakeLists.txt <span style="color: grey">(6320a19)</span></li>
<li>staging/xmlgui/autotests/CMakeLists.txt <span style="color: grey">(83c2b11)</span></li>
<li>staging/xmlgui/src/CMakeLists.txt <span style="color: grey">(a506ab0)</span></li>
<li>staging/xmlgui/src/config-xmlgui.h.cmake <span style="color: grey">(58949d8)</span></li>
<li>staging/xmlgui/tests/CMakeLists.txt <span style="color: grey">(dce637f)</span></li>
<li>staging/xmlgui/tests/kxmlguitest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111210/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>