<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111183/">http://git.reviewboard.kde.org/r/111183/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't understand the description of the change. It says "KLocale code is commented", but I don't see KLocal* anywhere. All I see is an apparently unused klocalizedstring.h include?</pre>
<br />
<p>- David</p>
<br />
<p>On July 2nd, 2013, 9:07 a.m. UTC, Andrea Scarpino wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Kevin Ottens.</div>
<div>By Andrea Scarpino.</div>
<p style="color: grey;"><i>Updated July 2, 2013, 9:07 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The KLocate code is commented. I don't know if this is OK, or if I've to port it to QLocale first and then it can be moved to kwidgets.
This patch must be applied with the others 2 that I'm going to push later.
KHelpMenu uses KLanguageButton through KSwitchLanguageDialogPrivate.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(abc7a2d)</span></li>
<li>kdeui/widgets/klanguagebutton.h <span style="color: grey">(feb2b5b)</span></li>
<li>kdeui/widgets/klanguagebutton.cpp <span style="color: grey">(c5d8e4b)</span></li>
<li>staging/kwidgets/src/CMakeLists.txt <span style="color: grey">(e337b81)</span></li>
<li>staging/kwidgets/src/widgets/klanguagebutton.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kwidgets/src/widgets/klanguagebutton.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111183/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>