<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111232/">http://git.reviewboard.kde.org/r/111232/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 3fad7c80c1abe47e3925b957547592e227fe106d by Wojciech Kapuscinski to branch frameworks.</pre>
<br />
<p>- Commit</p>
<br />
<p>On June 27th, 2013, 6:38 p.m. UTC, Wojciech Kapuscinski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Kevin Ottens.</div>
<div>By Wojciech Kapuscinski.</div>
<p style="color: grey;"><i>Updated June 27, 2013, 6:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">move klineedit and kcompletionbox to KCompletion framework
Notes:
KIconTheme::assignIconsToContextMenu( KIconTheme::TextEditor, popup->actions () ) removed because there is task in Qt5 Epics (Add icons to QLineEdit context menu (via qstyle?)).
Can we cut dependency do KIconThemes too?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it builds</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kde4attic/src/CMakeLists.txt <span style="color: grey">(0cf1be7)</span></li>
<li>staging/kcompletion/tests/CMakeLists.txt <span style="color: grey">(e8e39f3)</span></li>
<li>staging/kcompletion/src/config-kcompletion.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kcompletion/src/CMakeLists.txt <span style="color: grey">(e502554)</span></li>
<li>staging/kcompletion/autotests/CMakeLists.txt <span style="color: grey">(f497c9a)</span></li>
<li>security/crypto/CMakeLists.txt <span style="color: grey">(e890d33)</span></li>
<li>kutils/CMakeLists.txt <span style="color: grey">(bfe8541)</span></li>
<li>kross/ui/CMakeLists.txt <span style="color: grey">(65e1abb)</span></li>
<li>knewstuff/knewstuff3/CMakeLists.txt <span style="color: grey">(41ea203)</span></li>
<li>kioslave/http/kcookiejar/CMakeLists.txt <span style="color: grey">(2dae665)</span></li>
<li>kfile/CMakeLists.txt <span style="color: grey">(bc48bf7)</span></li>
<li>kdeui/widgets/klineedit_p.h <span style="color: grey">(7c58f2d)</span></li>
<li>kdeui/widgets/klineedit.cpp <span style="color: grey">(24920a8)</span></li>
<li>kdeui/widgets/klineedit.h <span style="color: grey">(7ac22f6)</span></li>
<li>kdeui/widgets/kcompletionbox.cpp <span style="color: grey">()</span></li>
<li>kdeui/widgets/kcompletionbox.h <span style="color: grey">(6e10dcf)</span></li>
<li>kdeui/tests/klineedittest.cpp <span style="color: grey">()</span></li>
<li>kdeui/tests/klineedittest.h <span style="color: grey">()</span></li>
<li>kdeui/tests/klineedit_unittest.cpp <span style="color: grey">()</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(fd8aa7b)</span></li>
<li>kdeui/CMakeLists.txt <span style="color: grey">(6d79682)</span></li>
<li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(551181c)</span></li>
<li>staging/kemoticons/tests/CMakeLists.txt <span style="color: grey">(3c59e7e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111232/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>