<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111191/">http://git.reviewboard.kde.org/r/111191/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111191/diff/2/?file=165569#file165569line43" style="color: black; font-weight: bold; text-decoration: underline;">staging/ktextwidgets/src/findreplace/kfinddialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#if 0</span><span class="c"></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Probably a good idea to use a name instead of 0, it'll be easier to grep through the files once KHistoryComboBox has been moved.
Once you got that symbol name don't forget to add a mention to it in the task corresponding to KHistoryComboBox so that people picking up that task won't forget to look in here.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111191/diff/2/?file=165570#file165570line72" style="color: black; font-weight: bold; text-decoration: underline;">staging/ktextwidgets/src/findreplace/kfinddialog_p.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">72</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">//KHistoryComboBox *find;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please use #if as before</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111191/diff/2/?file=165570#file165570line89" style="color: black; font-weight: bold; text-decoration: underline;">staging/ktextwidgets/src/findreplace/kfinddialog_p.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">89</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">//KHistoryComboBox *replace;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please use #if as before</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111191/diff/2/?file=165576#file165576line710" style="color: black; font-weight: bold; text-decoration: underline;">staging/ktextwidgets/src/widgets/ktextedit.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">710</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">KTextEdit</span><span class="o">::</span><span class="n">wheelEvent</span><span class="p">(</span> <span class="n">QWheelEvent</span> <span class="o">*</span><span class="n">event</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You can remove wheelEvent() altogether (same thing in the header).</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On June 24th, 2013, 8:45 a.m. UTC, Andrea Scarpino wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Andrea Scarpino.</div>
<p style="color: grey;"><i>Updated June 24, 2013, 8:45 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move KFind, KFindDialog, KReplace, KReplaceDialog, KTextEdit to KTextWidgets.
Notes:
* the dependency on kglobalsettings.h has been commented, otherwise a cycle-dependency is created here (KHelpMenu from XmlGui needs KTextEdit through KBugReport). What to do?
* the usage of KHistoryComboBox has been commented. Can be commented out when KHistoryComboBox is moved to staging.
Needs https://git.reviewboard.kde.org/r/111183/.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds and tests passed. kreplacetest segfaults.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(3946ebf)</span></li>
<li>kdeui/findreplace/kfind.h <span style="color: grey">(cf65e39)</span></li>
<li>kdeui/findreplace/kfind.cpp <span style="color: grey">(02e5236)</span></li>
<li>kdeui/findreplace/kfind_p.h <span style="color: grey">(53b9870)</span></li>
<li>kdeui/findreplace/kfinddialog.h <span style="color: grey">(39de50c)</span></li>
<li>kdeui/findreplace/kfinddialog.cpp <span style="color: grey">(c760e89)</span></li>
<li>kdeui/findreplace/kfinddialog_p.h <span style="color: grey">(019231f)</span></li>
<li>kdeui/findreplace/kreplace.h <span style="color: grey">(a4e2c75)</span></li>
<li>kdeui/findreplace/kreplace.cpp <span style="color: grey">(b8d509e)</span></li>
<li>kdeui/findreplace/kreplacedialog.h <span style="color: grey">(2416db1)</span></li>
<li>kdeui/findreplace/kreplacedialog.cpp <span style="color: grey">(0af24ec)</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(2dd4079)</span></li>
<li>kdeui/tests/kfindtest.h <span style="color: grey">(648ee8a)</span></li>
<li>kdeui/tests/kfindtest.cpp <span style="color: grey">(369e6eb)</span></li>
<li>kdeui/tests/kreplacetest.h <span style="color: grey">(72674eb)</span></li>
<li>kdeui/tests/kreplacetest.cpp <span style="color: grey">(83e00a0)</span></li>
<li>kdeui/tests/ktextedit_unittest.cpp <span style="color: grey">(9d77574)</span></li>
<li>kdeui/tests/ktextedittest.cpp <span style="color: grey">(0509627)</span></li>
<li>kdeui/widgets/ktextedit.h <span style="color: grey">(0a0bbf6)</span></li>
<li>kdeui/widgets/ktextedit.cpp <span style="color: grey">(4605bfd)</span></li>
<li>staging/CMakeLists.txt <span style="color: grey">(c7d0ede)</span></li>
<li>staging/ktextwidgets/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/ktextwidgets/autotests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/ktextwidgets/autotests/kfindtest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/ktextwidgets/autotests/kfindtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/ktextwidgets/autotests/kreplacetest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/ktextwidgets/autotests/kreplacetest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/ktextwidgets/autotests/ktextedit_unittest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/ktextwidgets/ktextwidgetsConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/ktextwidgets/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/ktextwidgets/src/findreplace/kfind.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/ktextwidgets/src/findreplace/kfind.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/ktextwidgets/src/findreplace/kfind_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/ktextwidgets/src/findreplace/kfinddialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/ktextwidgets/src/findreplace/kfinddialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/ktextwidgets/src/findreplace/kfinddialog_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/ktextwidgets/src/findreplace/kreplace.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/ktextwidgets/src/findreplace/kreplace.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/ktextwidgets/src/findreplace/kreplacedialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/ktextwidgets/src/findreplace/kreplacedialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/ktextwidgets/src/widgets/ktextedit.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/ktextwidgets/src/widgets/ktextedit.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/ktextwidgets/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/ktextwidgets/tests/ktextedittest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111191/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>