<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111081/">http://git.reviewboard.kde.org/r/111081/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated June 20, 2013, 10:22 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Renamed to "job ui delegate extension" after Kévin's suggestion.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KIO::Job: more core/gui splitup.
job->ui() no longer returns a KIO-specific class which was holding
QWidget* window and usertimestamp. It now returns the core-only base
class, like in KJob. The widget-specific information is stored as
a dynamic property into the job, using KJobWidgets API.
Split out a "job ui delegate extension" in kio, used for the rename
and skip dialog shown by copyjob and movejob.
REVIEW: 111081</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">make test</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KDE5PORTING.html <span style="color: grey">(9cac0c69861b999d968c7af5bdeb113b17086b86)</span></li>
<li>kio/kio/copyjob.cpp <span style="color: grey">(e403735f05d644463122728af3a0694454d31367)</span></li>
<li>kio/kio/job.cpp <span style="color: grey">(365752866ef44d79b42c41af38b446c9fd407c7b)</span></li>
<li>kio/kio/job_p.h <span style="color: grey">(e1dd97995825a372d81a8098e0da38bb821b7a20)</span></li>
<li>kio/kio/jobclasses.h <span style="color: grey">(27a0f12788d35b95934ac714b58df99478e36c31)</span></li>
<li>kio/kio/jobuidelegate.h <span style="color: grey">(87d9d2777f8bd28e417f54900bf85826fef7fa9b)</span></li>
<li>kio/kio/jobuidelegate.cpp <span style="color: grey">(9f7e1b2093bb22fff5105bdc958ef519bbee8fcb)</span></li>
<li>kio/kio/renamedialog.h <span style="color: grey">(2b9efe21bb5266ced199d2be9b2f8e45df2be4d3)</span></li>
<li>kio/kio/skipdialog.h <span style="color: grey">(93dd30958377fb997a9f10fa2c3cba7702b14350)</span></li>
<li>kio/kio/skipdialog.cpp <span style="color: grey">(98251e058704ef7b8f7fc9b349d8da95c121d2ae)</span></li>
<li>kio/tests/jobtest.cpp <span style="color: grey">(7a50857eee19faee995ebbe30e5ba0f954cc858d)</span></li>
<li>kio/tests/kdirmodeltest.cpp <span style="color: grey">(6d9f89070d8579bccb494cbeca080498627e2b1e)</span></li>
<li>kio/tests/kiotesthelper.h <span style="color: grey">(6ecf13409d0117148cc52c774aa5fced37a28e1d)</span></li>
<li>staging/kio/src/core/CMakeLists.txt <span style="color: grey">(9c243a30a9bda02847335c42efd88b6618862c34)</span></li>
<li>staging/kio/src/core/abstractjobinteractioninterface.h <span style="color: grey">(3cf9ffa7e07fa6c51473316b16f8b1b8a7d9b7f2)</span></li>
<li>staging/kio/src/core/abstractjobinteractioninterface.cpp <span style="color: grey">(a54c5d6da7e0ed0558cd3463f8cfe3755449bbfb)</span></li>
<li>staging/kio/src/core/jobuidelegateextension.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kio/src/core/jobuidelegateextension.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kdialogjobuidelegate.h <span style="color: grey">(f33d34911db53f6e1a90589e70bc9396f049ffc4)</span></li>
<li>staging/kjobwidgets/src/kdialogjobuidelegate.cpp <span style="color: grey">(a79eda86f8df34c6996a2f7285ba05466c6f8097)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111081/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>