<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111103/">http://git.reviewboard.kde.org/r/111103/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 3deb3f51251c1eeb55b544cc4d9f1e2fa2a4269f by Aleix Pol to branch frameworks.</pre>
 <br />









<p>- Commit</p>


<br />
<p>On June 18th, 2013, 5:32 p.m. UTC, Aleix Pol Gonzalez wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>


<p style="color: grey;"><i>Updated June 18, 2013, 5:32 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When I moved KPage*, I moved it to KWidgets because I thought we needed the KGlobalSettings dependency, but then we did some magic so that it wasn't needed.

This patch moves it where it belongs.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">builds</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>staging/kwidgets/src/CMakeLists.txt <span style="color: grey">(c019756)</span></li>

 <li>staging/kwidgets/src/paged/kpagedialog.h <span style="color: grey">(382e70d)</span></li>

 <li>staging/kwidgets/src/paged/kpagedialog.cpp <span style="color: grey">(542d6a2)</span></li>

 <li>staging/kwidgets/src/paged/kpagedialog_p.h <span style="color: grey">(7eff46b)</span></li>

 <li>staging/kwidgets/src/paged/kpagemodel.h <span style="color: grey">(6b10b78)</span></li>

 <li>staging/kwidgets/src/paged/kpagemodel.cpp <span style="color: grey">(5e5cfa7)</span></li>

 <li>staging/kwidgets/src/paged/kpagemodel_p.h <span style="color: grey">(6466f64)</span></li>

 <li>staging/kwidgets/src/paged/kpageview.h <span style="color: grey">(db624db)</span></li>

 <li>staging/kwidgets/src/paged/kpageview.cpp <span style="color: grey">(d250f32)</span></li>

 <li>staging/kwidgets/src/paged/kpageview_p.h <span style="color: grey">(1058579)</span></li>

 <li>staging/kwidgets/src/paged/kpageview_p.cpp <span style="color: grey">(180d3bc)</span></li>

 <li>staging/kwidgets/src/paged/kpagewidget.h <span style="color: grey">(a782468)</span></li>

 <li>staging/kwidgets/src/paged/kpagewidget.cpp <span style="color: grey">(e81ab57)</span></li>

 <li>staging/kwidgets/src/paged/kpagewidget_p.h <span style="color: grey">(6eeaeccb)</span></li>

 <li>staging/kwidgets/src/paged/kpagewidgetmodel.h <span style="color: grey">(a53de9a)</span></li>

 <li>staging/kwidgets/src/paged/kpagewidgetmodel.cpp <span style="color: grey">(0c38059)</span></li>

 <li>staging/kwidgets/src/paged/kpagewidgetmodel_p.h <span style="color: grey">(8ab48e6)</span></li>

 <li>staging/kwidgets/tests/CMakeLists.txt <span style="color: grey">(564d653)</span></li>

 <li>staging/kwidgets/tests/kpagedialogtest.h <span style="color: grey">(a5e9be5)</span></li>

 <li>staging/kwidgets/tests/kpagedialogtest.cpp <span style="color: grey">(b0e8efd)</span></li>

 <li>staging/kwidgets/tests/kpagewidgettest.h <span style="color: grey">(206255b)</span></li>

 <li>staging/kwidgets/tests/kpagewidgettest.cpp <span style="color: grey">(a767401)</span></li>

 <li>tier1/kwidgetsaddons/src/CMakeLists.txt <span style="color: grey">(7a58c0e)</span></li>

 <li>tier1/kwidgetsaddons/src/kpagedialog.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/src/kpagedialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/src/kpagedialog_p.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/src/kpagemodel.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/src/kpagemodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/src/kpagemodel_p.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/src/kpageview.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/src/kpageview.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/src/kpageview_p.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/src/kpageview_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/src/kpagewidget.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/src/kpagewidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/src/kpagewidget_p.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/src/kpagewidgetmodel.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/src/kpagewidgetmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/src/kpagewidgetmodel_p.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/tests/CMakeLists.txt <span style="color: grey">(53c21fc)</span></li>

 <li>tier1/kwidgetsaddons/tests/kpagedialogtest.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/tests/kpagedialogtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/tests/kpagewidgettest.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/tests/kpagewidgettest.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111103/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>