<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111105/">http://git.reviewboard.kde.org/r/111105/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111105/diff/2/?file=164468#file164468line49" style="color: black; font-weight: bold; text-decoration: underline;">staging/kwallet/src/kwallet.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace KWallet {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">49</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">class</span> <span class="n">QDBusError</span><span class="p">;</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">49</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">class</span> <span class="n">QDBusError</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Turns out that line is not necessary. If you could remove it since you're at it. Thanks.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111105/diff/2/?file=164479#file164479line29" style="color: black; font-weight: bold; text-decoration: underline;">staging/kwallet/src/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">KWallet</span> <span class="s">LINK_PUBLIC</span> <span class="s">Qt5::Widgets</span> <span class="s">Qt5::DBus</span> <span class="o">${</span><span class="nv">KWindowSystem_LIBRARIES</span><span class="o">}</span> <span class="s">KConfigCore</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Are they all public? It looks like only Qt5::Widgets is, the other ones could go in a LINK_PRIVATE line AFAICT. That would give:
target_link_libraries(KWallet LINK_PUBLIC Qt5::Widgets)
target_link_libraries(KWallet LINK_PRIVATE Qt5::DBus ${KWindowSystem_LIBRARIES} KConfigCore)
Also why ${KWindowSystem_LIBRARIES} and not simply KWindowSystem. It should work just like KConfigCore, it not let us know, that would be a bug.</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On June 18th, 2013, 10:38 p.m. UTC, Wojciech Kapuscinski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Kevin Ottens.</div>
<div>By Wojciech Kapuscinski.</div>
<p style="color: grey;"><i>Updated June 18, 2013, 10:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Create KWallet framework and move kwallet.h and others.
Notes:
Port aways from kdebug
remove unused includes
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It builds on Linux.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(0f2a0a9)</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(482581c)</span></li>
<li>kdeui/tests/kwallettest.h <span style="color: grey">()</span></li>
<li>kdeui/tests/kwallettest.cpp <span style="color: grey">(7a91a29)</span></li>
<li>kdeui/util/config-kwallet.h.cmake <span style="color: grey">()</span></li>
<li>kdeui/util/kwallet.h <span style="color: grey">(eb46a89)</span></li>
<li>kdeui/util/kwallet.cpp <span style="color: grey">(7016b51)</span></li>
<li>kdeui/util/kwallet_mac.cpp <span style="color: grey">(ce09f93)</span></li>
<li>kdeui/util/org.kde.KWallet.xml <span style="color: grey">()</span></li>
<li>kdewebkit/CMakeLists.txt <span style="color: grey">(93a44e9)</span></li>
<li>khtml/CMakeLists.txt <span style="color: grey">(010eb95)</span></li>
<li>kio/CMakeLists.txt <span style="color: grey">(a29905e)</span></li>
<li>staging/CMakeLists.txt <span style="color: grey">(4e4132b)</span></li>
<li>staging/kwallet/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kwallet/KWalletConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kwallet/autotests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kwallet/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kwallet/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111105/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>