<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111002/">http://git.reviewboard.kde.org/r/111002/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmmmm very odd, it looks like kviewstatemaintainer.cpp content is almost exactly the same than kviewstatemaintainerbase.cpp content... It's weird that we didn't get problems out of that, there's two identical implementation provided for the same symbol.
I think you could let kviewstatemaintainer.cpp go.</pre>
<br />
<p>- Kevin</p>
<br />
<p>On June 17th, 2013, 1:56 p.m. UTC, Wojciech Kapuscinski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Kevin Ottens.</div>
<div>By Wojciech Kapuscinski.</div>
<p style="color: grey;"><i>Updated June 17, 2013, 1:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">simple move
Note.
KViewStateSaver is typedef. lxr says that only one class use KViewStateSaver. Remove this kviewstatesaver.h header?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it builds and tests all OK</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(1dcf6db)</span></li>
<li>kdeui/itemviews/kviewstatemaintainer.h <span style="color: grey">(5ae9797)</span></li>
<li>kdeui/itemviews/kviewstatemaintainer.cpp <span style="color: grey">(cb788ed)</span></li>
<li>kdeui/itemviews/kviewstatesaver.h <span style="color: grey">(4384974)</span></li>
<li>staging/kconfigwidgets/src/CMakeLists.txt <span style="color: grey">(534b95d)</span></li>
<li>staging/kconfigwidgets/src/kviewstatemaintainer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kconfigwidgets/src/kviewstatemaintainer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(bb26c4e)</span></li>
<li>staging/kde4support/src/kdeui/kviewstatesaver.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111002/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>