<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110997/">http://git.reviewboard.kde.org/r/110997/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit a21f7e02972e9e438ea5bfe58bcd8433fa458031 by Aleix Pol to branch frameworks.</pre>
<br />
<p>- Commit</p>
<br />
<p>On June 17th, 2013, 3:19 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated June 17, 2013, 3:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Moved KPage*
Also ported the KPageListViewDelegate from using KIconLoader to get the icons size to QStyle. This makes it not possible to react to changes in the icon themes which shouldn't happen that often, and cuts a dependency instead.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Everything builds, the test seems good.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(46196b4)</span></li>
<li>kdeui/dialogs/kassistantdialog.h <span style="color: grey">(373e6cf)</span></li>
<li>kdeui/dialogs/kconfigdialog.h <span style="color: grey">(ea342ac)</span></li>
<li>kdeui/paged/kpagedialog.h <span style="color: grey">(77a58d0)</span></li>
<li>kdeui/paged/kpagedialog.cpp <span style="color: grey">()</span></li>
<li>kdeui/paged/kpagedialog_p.h <span style="color: grey">(3893ba9)</span></li>
<li>kdeui/paged/kpagemodel.h <span style="color: grey">(6645c4e)</span></li>
<li>kdeui/paged/kpagemodel.cpp <span style="color: grey">()</span></li>
<li>kdeui/paged/kpagemodel_p.h <span style="color: grey">()</span></li>
<li>kdeui/paged/kpageview.h <span style="color: grey">(2d9fbe1)</span></li>
<li>kdeui/paged/kpageview.cpp <span style="color: grey">(6648e34)</span></li>
<li>kdeui/paged/kpageview_p.h <span style="color: grey">(6404cd6)</span></li>
<li>kdeui/paged/kpageview_p.cpp <span style="color: grey">(42bdfe3)</span></li>
<li>kdeui/paged/kpagewidget.h <span style="color: grey">(6cebef7)</span></li>
<li>kdeui/paged/kpagewidget.cpp <span style="color: grey">(7bbfeb2)</span></li>
<li>kdeui/paged/kpagewidget_p.h <span style="color: grey">()</span></li>
<li>kdeui/paged/kpagewidgetmodel.h <span style="color: grey">(0769a48)</span></li>
<li>kdeui/paged/kpagewidgetmodel.cpp <span style="color: grey">(c5f6e41)</span></li>
<li>kdeui/paged/kpagewidgetmodel_p.h <span style="color: grey">(40c5fac)</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(8746397)</span></li>
<li>kdeui/tests/kpagedialogtest.h <span style="color: grey">()</span></li>
<li>kdeui/tests/kpagedialogtest.cpp <span style="color: grey">()</span></li>
<li>kdeui/tests/kpagewidgettest.h <span style="color: grey">()</span></li>
<li>kdeui/tests/kpagewidgettest.cpp <span style="color: grey">()</span></li>
<li>kio/CMakeLists.txt <span style="color: grey">(6af7b6d)</span></li>
<li>kutils/CMakeLists.txt <span style="color: grey">(0276030)</span></li>
<li>staging/kwidgets/src/CMakeLists.txt <span style="color: grey">(03a7d7a)</span></li>
<li>staging/kwidgets/tests/CMakeLists.txt <span style="color: grey">(f173b80)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110997/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>