<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110995/">http://git.reviewboard.kde.org/r/110995/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, managed to make a first pass of review nonetheless. For future reference, please make two commits (and then reviews) in situations like this: one for the dependencies related adjustments, one for the actual move. It's easier to review, and it'll be easier for bug hunting and history management later on.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110995/diff/4/?file=150318#file150318line32" style="color: black; font-weight: bold; text-decoration: underline;">staging/kjobwidgets/src/kjobtrackerformatters_p.h</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">32</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">byteSize</span><span class="p">(</span><span class="kt">double</span> <span class="n">size</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You removed an empty line just after that one. It was a useless change, please reintroduce that empty line.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110995/diff/4/?file=150320#file150320line243" style="color: black; font-weight: bold; text-decoration: underline;">staging/kjobwidgets/src/kstatusbarjobtracker.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">243</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">label</span><span class="o">-></span><span class="n">setText</span><span class="p">(</span><span class="n">QObject</span><span class="o">::</span><span class="n">tr</span><span class="p">(</span><span class="s">" Stalled "</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please use just tr() here. Will require using Q_DECLARE_TR_FUNCTIONS in KStatusJobTracker::Private declaration though.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110995/diff/4/?file=150320#file150320line245" style="color: black; font-weight: bold; text-decoration: underline;">staging/kjobwidgets/src/kstatusbarjobtracker.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">245</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">label</span><span class="o">-></span><span class="n">setText</span><span class="p">(</span><span class="n">QObject</span><span class="o">::</span><span class="n">tr</span><span class="p">(</span><span class="s">" %1/s "</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">KJobTrackerFormatters</span><span class="o">::</span><span class="n">byteSize</span><span class="p">(</span><span class="n">value</span><span class="p">)));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ditto</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110995/diff/4/?file=150324#file150324line270" style="color: black; font-weight: bold; text-decoration: underline;">staging/kjobwidgets/src/kwidgetjobtracker.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">270</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">trContext</span> <span class="o">=</span> <span class="n">QString</span><span class="p">(</span><span class="s">"%1 is the label, we add a ':' to it"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">field1</span><span class="p">.</span><span class="n">first</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think you should avoid using a variable for the context. Pass this one directly and get rid of trContext (otherwise the context won't get extracted properly IIRC).</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110995/diff/4/?file=150324#file150324line271" style="color: black; font-weight: bold; text-decoration: underline;">staging/kjobwidgets/src/kwidgetjobtracker.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">271</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">sourceInvite</span><span class="o">-></span><span class="n">setText</span><span class="p">(</span><span class="n">QObject</span><span class="o">::</span><span class="n">tr</span><span class="p">(</span><span class="s">"%1:"</span><span class="p">,</span> <span class="n">trContext</span><span class="p">.</span><span class="n">toLatin1</span><span class="p">().</span><span class="n">data</span><span class="p">()).</span><span class="n">arg</span><span class="p">(</span><span class="n">field1</span><span class="p">.</span><span class="n">first</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please use just tr() here. Will require using Q_DECLARE_TR_FUNCTIONS in KWidgetJobTracker::Private declaration though.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110995/diff/4/?file=150324#file150324line280" style="color: black; font-weight: bold; text-decoration: underline;">staging/kjobwidgets/src/kwidgetjobtracker.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">280</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">destInvite</span><span class="o">-></span><span class="n">setText</span><span class="p">(</span><span class="n">QObject</span><span class="o">::</span><span class="n">tr</span><span class="p">(</span><span class="s">"%1:"</span><span class="p">,</span> <span class="n">trContext</span><span class="p">.</span><span class="n">toLatin1</span><span class="p">().</span><span class="n">data</span><span class="p">()).</span><span class="n">arg</span><span class="p">(</span><span class="n">field2</span><span class="p">.</span><span class="n">first</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ditto</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110995/diff/4/?file=150324#file150324line402" style="color: black; font-weight: bold; text-decoration: underline;">staging/kjobwidgets/src/kwidgetjobtracker.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">402</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KGuiItem</span><span class="o">::</span><span class="n">assign</span><span class="p">(</span><span class="n">cancelClose</span><span class="p">,</span> <span class="n">KGuiItem</span><span class="p">(</span> <span class="n">tr</span><span class="p">(</span> <span class="s">"&Close"</span> <span class="p">),</span> <span class="s">"window-close"</span><span class="p">,</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You probably could even get rid of KGuiItem here.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110995/diff/4/?file=150324#file150324line443" style="color: black; font-weight: bold; text-decoration: underline;">staging/kjobwidgets/src/kwidgetjobtracker.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">443</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">//KWindowSystem::setIcons( winId(),</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Get rid of those comments</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110995/diff/4/?file=150324#file150324line446" style="color: black; font-weight: bold; text-decoration: underline;">staging/kjobwidgets/src/kwidgetjobtracker.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">446</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setWindowIcon</span><span class="p">(</span><span class="n">QIcon</span><span class="o">::</span><span class="n">fromTheme</span><span class="p">(</span><span class="s">"document-save"</span><span class="p">).</span><span class="n">pixmap</span><span class="p">(</span><span class="mi">32</span><span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Don't call pixmap(32) on the icon. setWindowIcon takes a QIcon as parameter, not a QPixmap.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110995/diff/4/?file=150324#file150324line543" style="color: black; font-weight: bold; text-decoration: underline;">staging/kjobwidgets/src/kwidgetjobtracker.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">543</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KGuiItem</span><span class="o">::</span><span class="n">assign</span><span class="p">(</span><span class="n">cancelClose</span><span class="p">,</span> <span class="n">KGuiItem</span><span class="p">(</span> <span class="n">tr</span><span class="p">(</span> <span class="s">"&Cancel"</span> <span class="p">),</span> <span class="s">"dialog-cancel"</span> <span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You probably could even get rid of KGuiItem here.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110995/diff/4/?file=150328#file150328line19" style="color: black; font-weight: bold; text-decoration: underline;">staging/kjobwidgets/tests/kjobtrackerstest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">19</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You inserted plenty of trailing whitespaces in that file, please fix them.</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On June 13th, 2013, 10:29 p.m. UTC, Wojciech Kapuscinski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Kevin Ottens.</div>
<div>By Wojciech Kapuscinski.</div>
<p style="color: grey;"><i>Updated June 13, 2013, 10:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">move jobs from kdeui to kjobswidgets framework
Port away from:
NET::timestampCompare
KWindowSystem::setIcon (QWidget.setWindowIcon)
ki18n (not sure if KWidgetJobTracker::Private::ProgressWidget::description() is correctly ported)
KStandardGuiItem
I'm not sure about plural translations (appears (s) because there is not English translation)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it builds and my tests shows now regressions (except plural translations (s) )</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(46196b4)</span></li>
<li>kdeui/jobs/kabstractwidgetjobtracker.h <span style="color: grey">(892e787)</span></li>
<li>kdeui/jobs/kabstractwidgetjobtracker.cpp <span style="color: grey">(0b9e829)</span></li>
<li>kdeui/jobs/kabstractwidgetjobtracker_p.h <span style="color: grey">(5f427e3)</span></li>
<li>kdeui/jobs/kdialogjobuidelegate.h <span style="color: grey">(186f160)</span></li>
<li>kdeui/jobs/kdialogjobuidelegate.cpp <span style="color: grey">(5afe6ec)</span></li>
<li>kdeui/jobs/kjobtrackerformatters.cpp <span style="color: grey">(95e8cfb)</span></li>
<li>kdeui/jobs/kjobtrackerformatters_p.h <span style="color: grey">(aeeb856)</span></li>
<li>kdeui/jobs/kstatusbarjobtracker.h <span style="color: grey">(dbab452)</span></li>
<li>kdeui/jobs/kstatusbarjobtracker.cpp <span style="color: grey">(688c942)</span></li>
<li>kdeui/jobs/kstatusbarjobtracker_p.h <span style="color: grey">(9d93e9c)</span></li>
<li>kdeui/jobs/kwidgetjobtracker.h <span style="color: grey">(761267f)</span></li>
<li>kdeui/jobs/kwidgetjobtracker.cpp <span style="color: grey">(835cad0)</span></li>
<li>kdeui/jobs/kwidgetjobtracker_p.h <span style="color: grey">(2a3f297)</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(8746397)</span></li>
<li>kdeui/tests/kjobtrackerstest.h <span style="color: grey">(c6f3195)</span></li>
<li>kdeui/tests/kjobtrackerstest.cpp <span style="color: grey">(bbde166)</span></li>
<li>staging/kjobwidgets/src/CMakeLists.txt <span style="color: grey">(84756ce)</span></li>
<li>staging/kjobwidgets/src/config-kjobwidgets.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kabstractwidgetjobtracker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kabstractwidgetjobtracker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kabstractwidgetjobtracker_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kdialogjobuidelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kdialogjobuidelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kjobtrackerformatters.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kjobtrackerformatters_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kstatusbarjobtracker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kstatusbarjobtracker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kstatusbarjobtracker_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kuiserverjobtracker.cpp <span style="color: grey">(13de2f4)</span></li>
<li>staging/kjobwidgets/src/kwidgetjobtracker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kwidgetjobtracker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kwidgetjobtracker_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/tests/CMakeLists.txt <span style="color: grey">(d41be07)</span></li>
<li>staging/kjobwidgets/tests/kjobtrackerstest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/tests/kjobtrackerstest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110995/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>