<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110995/">http://git.reviewboard.kde.org/r/110995/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Kevin Ottens.</div>
<div>By Wojciech Kapuscinski.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">move jobs from kdeui to kjobswidgets framework
Port away from:
NET::timestampCompare
KWindowSystem::setIcon (QWidget.setWindowIcon)
ki18n (not sure if KWidgetJobTracker::Private::ProgressWidget::description() is correctly ported)
KStandardGuiItem
I'm not sure about plural translations (appears (s) because there is not English translation)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it builds and my tests shows now regressions (except plural translations (s) )</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(8746397)</span></li>
<li>kdeui/tests/kjobtrackerstest.h <span style="color: grey">(c6f3195)</span></li>
<li>kdeui/tests/kjobtrackerstest.cpp <span style="color: grey">(bbde166)</span></li>
<li>staging/kjobwidgets/src/CMakeLists.txt <span style="color: grey">(84756ce)</span></li>
<li>staging/kjobwidgets/src/config-kjobwidgets.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kabstractwidgetjobtracker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kabstractwidgetjobtracker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kabstractwidgetjobtracker_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kdialogjobuidelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kdialogjobuidelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kjobtrackerformatters.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kjobtrackerformatters_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kstatusbarjobtracker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kstatusbarjobtracker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kstatusbarjobtracker_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kuiserverjobtracker.cpp <span style="color: grey">(13de2f4)</span></li>
<li>staging/kjobwidgets/src/kwidgetjobtracker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kwidgetjobtracker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/src/kwidgetjobtracker_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kjobwidgets/tests/CMakeLists.txt <span style="color: grey">(d41be07)</span></li>
<li>staging/kjobwidgets/tests/kjobtrackerstest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kdeui/jobs/kwidgetjobtracker_p.h <span style="color: grey">(2a3f297)</span></li>
<li>kdeui/jobs/kwidgetjobtracker.cpp <span style="color: grey">(835cad0)</span></li>
<li>kdeui/jobs/kwidgetjobtracker.h <span style="color: grey">(761267f)</span></li>
<li>kdeui/jobs/kstatusbarjobtracker_p.h <span style="color: grey">(9d93e9c)</span></li>
<li>kdeui/jobs/kstatusbarjobtracker.cpp <span style="color: grey">(688c942)</span></li>
<li>kdeui/jobs/kstatusbarjobtracker.h <span style="color: grey">(dbab452)</span></li>
<li>kdeui/jobs/kjobtrackerformatters_p.h <span style="color: grey">(aeeb856)</span></li>
<li>kdeui/jobs/kjobtrackerformatters.cpp <span style="color: grey">(95e8cfb)</span></li>
<li>kdeui/jobs/kdialogjobuidelegate.cpp <span style="color: grey">(5afe6ec)</span></li>
<li>kdeui/jobs/kdialogjobuidelegate.h <span style="color: grey">(186f160)</span></li>
<li>kdeui/jobs/kabstractwidgetjobtracker_p.h <span style="color: grey">(5f427e3)</span></li>
<li>kdeui/jobs/kabstractwidgetjobtracker.cpp <span style="color: grey">(0b9e829)</span></li>
<li>kdeui/CMakeLists.txt <span style="color: grey">(46196b4)</span></li>
<li>kdeui/jobs/kabstractwidgetjobtracker.h <span style="color: grey">(892e787)</span></li>
<li>staging/kjobwidgets/tests/kjobtrackerstest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110995/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>