<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110988/">http://git.reviewboard.kde.org/r/110988/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 13th, 2013, 11:06 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good work, not an easy task.
In addition to the issues I found, could you ensure that the unittests still pass? In particular jobtest in kio, looks appropriate. Plus the one that calls chmod().</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Will do.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 13th, 2013, 11:06 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110988/diff/1/?file=149805#file149805line191" style="color: black; font-weight: bold; text-decoration: underline;">kioslave/file/file.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int FileProtocol::setACL( const char *path, mode_t perm, bool directoryDefault )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">188</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">(</span> <span class="n">setACL</span><span class="p">(</span> <span class="n">_path</span><span class="p">.</span><span class="n">data</span><span class="p">(),</span> <span class="n">permissions</span><span class="p">,</span> <span class="nb">false</span> <span class="p">)</span> <span class="o">==</span> <span class="o">-</span><span class="mi">1</span> <span class="p">)</span> <span class="o">||</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">191</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span> <span class="o">!</span><span class="n">f</span><span class="p">.</span><span class="n">setPermissions</span><span class="p">((</span><span class="n">QFileDevice</span><span class="o">::</span><span class="n">Permission</span><span class="p">)</span><span class="n">permissions</span> <span class="p">)</span> <span class="o">||</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You cannot cast from mode_t to QFileDevice::Permissions. They are different enums with different values.
SlaveBase::chmod() has to be ported to QFileDevice::Permissions - and all kioslaves, or this will have to stay being a mode_t.
One issue with QFileDevice::Permissions is that it doesn't have support for SUID and SGID, but only root can set that anyway, so one could say it's out of scope for KDE - or at best, can be handled locally in kpropertiesdialog.cpp.
So I'm OK with a port to QFileDevice::Permissions -- but the signature of chmod() should change to avoid any ambiguity between mode_t and Permissions, and obviously the calling code in libkio has to be adjusted too. All this should probably be a different patch, so I'd leave this one with mode_t and ::chmod() for now.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, will revert for now and do a separate patch.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 13th, 2013, 11:06 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110988/diff/1/?file=149805#file149805line453" style="color: black; font-weight: bold; text-decoration: underline;">kioslave/file/file.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void FileProtocol::open(const QUrl &url, QIODevice::OpenMode mode)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">438</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">error</span><span class="p">(</span><span class="n">KIO</span><span class="o">::</span><span class="n">ERR_CANNOT_OPEN_FOR_READING</span><span class="p">,</span> <span class="n">openPath</span><span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">409</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">error</span><span class="p">(</span><span class="n">KIO</span><span class="o">::</span><span class="n">ERR_CANNOT_OPEN_FOR_READING</span><span class="p">,</span> <span class="n">openPath</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bug in the original code? Should be ..._FOR_WRITING if mode & QIODevice::WriteOnly?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Would
if (mode & QIODevice::ReadOnly) {
error(KIO::ERR_CANNOT_OPEN_FOR_READING, openPath);
} else {
error(KIO::ERR_CANNOT_OPEN_FOR_WRITING, openPath);
}
work? As the rest of the modes (WriteOnly, ReadWrite, Append, Truncate) assumes writing</pre>
<br />
<p>- Martin</p>
<br />
<p>On June 13th, 2013, 10:40 a.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated June 13, 2013, 10:40 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ports away kioslave/file from unix/kde specific calls to QFile calls</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/file/file.h <span style="color: grey">(93aeef4)</span></li>
<li>kioslave/file/file.cpp <span style="color: grey">(d57517b)</span></li>
<li>kioslave/file/file_unix.cpp <span style="color: grey">(8b92e06)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110988/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>