<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107696/">http://git.reviewboard.kde.org/r/107696/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 6th, 2013, 11:40 a.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Jon, AFAICT this patch hasn't been pushed and it's been way more than a week. Any reason why you didn't push after all?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me too. Jon, please push your commits (we can't apply this one since you have other git commits to push with it, like moving stuff to kcalendarsystemweek.cpp, you said....</pre>
<br />
<p>- David</p>
<br />
<p>On January 19th, 2013, 12:41 p.m. UTC, Jon Severinsson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure and John Layt.</div>
<div>By Jon Severinsson.</div>
<p style="color: grey;"><i>Updated Jan. 19, 2013, 12:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Weekday names depend on *language*, not calendar system. The usual ki18nc can handle it just fine, so consolidate it all to a single function.
Note: Before this patch I'm moving some functions to a new file "kcalendarsystemweek.cpp" in order move to out of the way of regular calendar system code. That commit changes no code whatsoever, so don't really need a review.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">`make test` shows no regressions</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/date/kcalendarsystem.h <span style="color: grey">(c121bb6)</span></li>
<li>kdecore/date/kcalendarsystem.cpp <span style="color: grey">(35877b7)</span></li>
<li>kdecore/date/kcalendarsystemcoptic.cpp <span style="color: grey">(86d35a9)</span></li>
<li>kdecore/date/kcalendarsystemcoptic_p.h <span style="color: grey">(5287271)</span></li>
<li>kdecore/date/kcalendarsystemcopticprivate_p.h <span style="color: grey">(8ceb5ad)</span></li>
<li>kdecore/date/kcalendarsystemethiopian.cpp <span style="color: grey">(9bfc41f)</span></li>
<li>kdecore/date/kcalendarsystemethiopian_p.h <span style="color: grey">(4f8119e)</span></li>
<li>kdecore/date/kcalendarsystemgregorian.cpp <span style="color: grey">(18b7aef)</span></li>
<li>kdecore/date/kcalendarsystemgregorian_p.h <span style="color: grey">(8890643)</span></li>
<li>kdecore/date/kcalendarsystemgregorianprivate_p.h <span style="color: grey">(1208fe9)</span></li>
<li>kdecore/date/kcalendarsystemhebrew.cpp <span style="color: grey">(660cb6d)</span></li>
<li>kdecore/date/kcalendarsystemhebrew_p.h <span style="color: grey">(132e21f)</span></li>
<li>kdecore/date/kcalendarsystemindiannational.cpp <span style="color: grey">(7c4fe03)</span></li>
<li>kdecore/date/kcalendarsystemindiannational_p.h <span style="color: grey">(499d2fa)</span></li>
<li>kdecore/date/kcalendarsystemislamiccivil.cpp <span style="color: grey">(abca3b5)</span></li>
<li>kdecore/date/kcalendarsystemislamiccivil_p.h <span style="color: grey">(6d4682f)</span></li>
<li>kdecore/date/kcalendarsystemjalali.cpp <span style="color: grey">(331f2b3)</span></li>
<li>kdecore/date/kcalendarsystemjalali_p.h <span style="color: grey">(c88d304)</span></li>
<li>kdecore/date/kcalendarsystemjapanese.cpp <span style="color: grey">(d8a870b)</span></li>
<li>kdecore/date/kcalendarsystemjapanese_p.h <span style="color: grey">(09bb4f4)</span></li>
<li>kdecore/date/kcalendarsystemjulian.cpp <span style="color: grey">(d1b5864)</span></li>
<li>kdecore/date/kcalendarsystemjulian_p.h <span style="color: grey">(5940c27)</span></li>
<li>kdecore/date/kcalendarsystemminguo.cpp <span style="color: grey">(165c86f)</span></li>
<li>kdecore/date/kcalendarsystemminguo_p.h <span style="color: grey">(0a3b5d7)</span></li>
<li>kdecore/date/kcalendarsystemprivate_p.h <span style="color: grey">(43b486f)</span></li>
<li>kdecore/date/kcalendarsystemweek.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kdecore/tests/kcalendartest.h <span style="color: grey">(ea5b836)</span></li>
<li>kdecore/tests/kcalendartest.cpp <span style="color: grey">(5c4d438)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107696/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>