<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110876/">http://git.reviewboard.kde.org/r/110876/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110876/diff/1/?file=149046#file149046line2007" style="color: black; font-weight: bold; text-decoration: underline;">khtml/xml/dom_docimpl.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void DocumentImpl::processHttpEquiv(const DOMString &equiv, const DOMString &content)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">2007</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">expire_date</span> <span class="o">=</span> <span class="n">str</span><span class="p">.</span><span class="n">toULong</span><span class="p">();</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2006</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">expire_date</span> <span class="o">=</span> <span class="n"><span class="hl">QDateTime</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">fromTime_t</span></span><span class="p"><span class="hl">(</span></span><span class="n">str</span><span class="p">.</span><span class="n">toULong</span><span class="p">()<span class="hl">)</span>;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This isn't about two QDateTimes.
It's about one QDateTime (m_creationDate) and one number of seconds, str.toULong(), relative to that creation date.
If you don't call fromTime_t(str.toULong) but rather, like the old code, interpret that as a number of seconds relative to the creation date, you won't have the issue of two qdatetimes.
In other words, this line should be
expire_date = m_creationDate.addSecs(str.toULong());
That's what the old code was doing (via relative=true).
No need to change the DocLoader methods further, AFAICS.</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On June 7th, 2013, 10:35 p.m. UTC, David Gil Oliva wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Gil Oliva.</div>
<p style="color: grey;"><i>Updated June 7, 2013, 10:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port time_t to QDateTime in Loader, KHTMLPart and DocumentImpl (KHTML)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It builds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>khtml/khtml_part.cpp <span style="color: grey">(a97ca0d8179a438a0ceb713100b5c335995ae9f4)</span></li>
<li>khtml/misc/loader.h <span style="color: grey">(5e9db0f8baef69c7bb146e4bd6c8cefcdbfe09c2)</span></li>
<li>khtml/misc/loader.cpp <span style="color: grey">(c8812755b99f841f6e7b90da8e154810c1f7c23f)</span></li>
<li>khtml/xml/dom_docimpl.cpp <span style="color: grey">(15f491857ebd17ef21a6df8e187ed16052974cca)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110876/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>