<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110907/">http://git.reviewboard.kde.org/r/110907/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Have we confirmed that Qt5 print dialog provides the options we have here? Otherwise it shouldn't go to kde4support, no?</pre>
<br />
<p>- Albert</p>
<br />
<p>On June 9th, 2013, 9:47 a.m. UTC, Anne-Marie Mahfouf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Anne-Marie Mahfouf.</div>
<p style="color: grey;"><i>Updated June 9, 2013, 9:47 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move kdeprintdialog.h and kcups* to kde4support
Fix compilation
Mark as deprecated
Things I am unsure of: the change in khtml/khtmlview.cpp and in kdeui/dialogs/kshortcutseditor.cpp, some CMakeLists moves as well are to be checked.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Build</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(3302cc0)</span></li>
<li>kdeui/dialogs/kcupsoptionsjobwidget.ui <span style="color: grey">(182b23e)</span></li>
<li>kdeui/dialogs/kcupsoptionsjobwidget_p.h <span style="color: grey">(9302f20)</span></li>
<li>kdeui/dialogs/kcupsoptionsjobwidget_p.cpp <span style="color: grey">(66b20b3)</span></li>
<li>kdeui/dialogs/kcupsoptionspageswidget.ui <span style="color: grey">(d2494c7)</span></li>
<li>kdeui/dialogs/kcupsoptionspageswidget_p.h <span style="color: grey">(ede67e6)</span></li>
<li>kdeui/dialogs/kcupsoptionspageswidget_p.cpp <span style="color: grey">(f99fc8f)</span></li>
<li>kdeui/dialogs/kcupsoptionssettingswidget_p.h <span style="color: grey">(8d26e33)</span></li>
<li>kdeui/dialogs/kcupsoptionssettingswidget_p.cpp <span style="color: grey">(7b58a37)</span></li>
<li>kdeui/dialogs/kcupsoptionswidget_p.h <span style="color: grey">(fc5c9e1)</span></li>
<li>kdeui/dialogs/kcupsoptionswidget_p.cpp <span style="color: grey">(363c0b8)</span></li>
<li>kdeui/dialogs/kdeprint_nup1.png <span style="color: grey">(9f13429be1d946ae682bd7b8b4e22850c3337b10)</span></li>
<li>kdeui/dialogs/kdeprint_nup2.png <span style="color: grey">(7289a7e68ea19dc0e767f3bfe3c4c316b03b143e)</span></li>
<li>kdeui/dialogs/kdeprint_nup4.png <span style="color: grey">(b03a539fc4eb586b836171745353cb5fc8963478)</span></li>
<li>kdeui/dialogs/kdeprint_nupother.png <span style="color: grey">(5a7c385866b335d4751a8adbec295dc096b53c30)</span></li>
<li>kdeui/dialogs/kdeprintdialog.h <span style="color: grey">(ce39771)</span></li>
<li>kdeui/dialogs/kdeprintdialog.cpp <span style="color: grey">(393aa9f)</span></li>
<li>kdeui/dialogs/kshortcutseditor.cpp <span style="color: grey">(5f84cac)</span></li>
<li>khtml/khtmlview.cpp <span style="color: grey">(69b527a)</span></li>
<li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(1f6edde)</span></li>
<li>staging/kde4support/src/kdeui/kcupsoptionsjobwidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/kdeui/kcupsoptionsjobwidget_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/kdeui/kcupsoptionsjobwidget_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/kdeui/kcupsoptionspageswidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/kdeui/kcupsoptionspageswidget_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/kdeui/kcupsoptionspageswidget_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/kdeui/kcupsoptionssettingswidget_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/kdeui/kcupsoptionssettingswidget_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/kdeui/kcupsoptionswidget_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/kdeui/kcupsoptionswidget_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/kdeui/kdeprint_nup1.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/kdeui/kdeprint_nup2.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/kdeui/kdeprint_nup4.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/kdeui/kdeprint_nupother.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/kdeui/kdeprintdialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/kdeui/kdeprintdialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110907/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>