<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110478/">http://git.reviewboard.kde.org/r/110478/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 21st, 2013, 10:35 a.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm for the kcupsoptionspageswidget.ui don't we need to also introduce a QButtonGroup on the C++ side? So that the radio buttons keep being mutually exclusive.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Radio buttons are autoExclusive by default (from doc) which I verified in the .ui file.
kdeui/dialogs/kconfigdialogmanager.cpp will be removed from the commit.
Another error in the initial patch is that kbuttongrouptest should be moved to staging/kde4support/autotests/ (and not staging/kde4support/tests) being initially in KDEUI_UNIT_TESTS.</pre>
<br />
<p>- Anne-Marie</p>
<br />
<p>On May 16th, 2013, 7:24 p.m. UTC, Anne-Marie Mahfouf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Kevin Ottens.</div>
<div>By Anne-Marie Mahfouf.</div>
<p style="color: grey;"><i>Updated May 16, 2013, 7:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port kcupsoptionspageswidget.ui to QGroupBox (I edited the .ui file in Designer from Qt5 for this hence the changes)
Move class files
Move test
Change export in header and ad deprecated comment</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It builds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(cfa29ef)</span></li>
<li>kdeui/dialogs/kconfigdialogmanager.cpp <span style="color: grey">(405799b)</span></li>
<li>kdeui/dialogs/kcupsoptionspageswidget.ui <span style="color: grey">(d2494c7)</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(cd055d5)</span></li>
<li>kdeui/tests/kbuttongrouptest.h <span style="color: grey">(cd9130a)</span></li>
<li>kdeui/tests/kbuttongrouptest.cpp <span style="color: grey">(93dd05e)</span></li>
<li>kdeui/widgets/kbuttongroup.h <span style="color: grey">(5bc89dd)</span></li>
<li>kdeui/widgets/kbuttongroup.cpp <span style="color: grey">(c4d918d)</span></li>
<li>kdewidgets/kde.widgets <span style="color: grey">(aa07c0f)</span></li>
<li>kdewidgets/kdedeprecated.widgets <span style="color: grey">(3adc0b2)</span></li>
<li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(a8e0a0c)</span></li>
<li>staging/kde4support/src/kdeui/kbuttongroup.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/kdeui/kbuttongroup.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/tests/CMakeLists.txt <span style="color: grey">(4115688)</span></li>
<li>staging/kde4support/tests/kbuttongrouptest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/tests/kbuttongrouptest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110478/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>