<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110845/">http://git.reviewboard.kde.org/r/110845/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110845/diff/1/?file=148829#file148829line18" style="color: black; font-weight: bold; text-decoration: underline;">staging/itemviews/src/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">10</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">ItemViews</span> <span class="s">LINK_PUBLIC</span> <span class="s">Qt5::Widgets</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">18</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">ItemViews</span> <span class="s">LINK_PUBLIC</span> <span class="s">Qt5::Widgets</span><span class="hl"> </span><span class="o"><span class="hl">${</span></span><span class="nv"><span class="hl">KCoreAddons_LIBRARIES</span></span><span class="o"><span class="hl">}</span></span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You could a comment that says why kcoreaddons is needed, for the next person wondering about that.</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On June 6th, 2013, 12:13 a.m. UTC, Wojciech Kapuscinski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Kevin Ottens.</div>
<div>By Wojciech Kapuscinski.</div>
<p style="color: grey;"><i>Updated June 6, 2013, 12:13 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Simple move form kdeui, added KCoreAddons dependency, reduced test dependency (port from KLineEdit and KMessageBox)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It builds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(80387ee)</span></li>
<li>kdeui/itemviews/kcategorizedsortfilterproxymodel.h <span style="color: grey">(0d7654f)</span></li>
<li>kdeui/itemviews/kcategorizedsortfilterproxymodel.cpp <span style="color: grey">(c8b652d)</span></li>
<li>kdeui/itemviews/kcategorizedsortfilterproxymodel_p.h <span style="color: grey">(eb1a67b)</span></li>
<li>kdeui/itemviews/kcategorizedview.h <span style="color: grey">(0342890)</span></li>
<li>kdeui/itemviews/kcategorizedview.cpp <span style="color: grey">(2175f02)</span></li>
<li>kdeui/itemviews/kcategorizedview_p.h <span style="color: grey">(4c175fb)</span></li>
<li>kdeui/itemviews/kcategorydrawer.h <span style="color: grey">(1ff872c)</span></li>
<li>kdeui/itemviews/kcategorydrawer.cpp <span style="color: grey">(ec60ebd)</span></li>
<li>kdeui/itemviews/kfilterproxysearchline.h <span style="color: grey">(88f05e7)</span></li>
<li>kdeui/itemviews/kfilterproxysearchline.cpp <span style="color: grey">(fe5d3bf)</span></li>
<li>kdeui/itemviews/klistwidgetsearchline.h <span style="color: grey">(1da01c7)</span></li>
<li>kdeui/itemviews/klistwidgetsearchline.cpp <span style="color: grey">(ebcf008)</span></li>
<li>kdeui/itemviews/ktreewidgetsearchline.h <span style="color: grey">(0d66007)</span></li>
<li>kdeui/itemviews/ktreewidgetsearchline.cpp <span style="color: grey">(6b57bb8)</span></li>
<li>kdeui/itemviews/kwidgetitemdelegate.h <span style="color: grey">(5f80eab)</span></li>
<li>kdeui/itemviews/kwidgetitemdelegate.cpp <span style="color: grey">(cdd0461)</span></li>
<li>kdeui/itemviews/kwidgetitemdelegate_p.h <span style="color: grey">(e606ec9)</span></li>
<li>kdeui/itemviews/kwidgetitemdelegatepool.cpp <span style="color: grey">(0776929)</span></li>
<li>kdeui/itemviews/kwidgetitemdelegatepool_p.h <span style="color: grey">(46bd38b)</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(33701b4)</span></li>
<li>kdeui/tests/klistwidgetsearchlinetest.cpp <span style="color: grey">(10bb491)</span></li>
<li>kdeui/tests/ktreewidgetsearchlinetest.h <span style="color: grey">(77fd758)</span></li>
<li>kdeui/tests/ktreewidgetsearchlinetest.cpp <span style="color: grey">(9ff3796)</span></li>
<li>kdeui/tests/kwidgetitemdelegatetest.cpp <span style="color: grey">(6c1fed9)</span></li>
<li>staging/itemviews/CMakeLists.txt <span style="color: grey">(620f6c6)</span></li>
<li>staging/itemviews/autotests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/itemviews/autotests/klistwidgetsearchlinetest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/itemviews/src/CMakeLists.txt <span style="color: grey">(db39b8a)</span></li>
<li>staging/itemviews/src/kcategorizedsortfilterproxymodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/itemviews/src/kcategorizedview.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/itemviews/src/kcategorizedview.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/itemviews/src/kcategorizedview_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/itemviews/src/kcategorydrawer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/itemviews/src/kcategorydrawer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/itemviews/src/kfilterproxysearchline.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/itemviews/src/kfilterproxysearchline.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/itemviews/src/klistwidgetsearchline.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/itemviews/src/klistwidgetsearchline.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/itemviews/src/ktreewidgetsearchline.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/itemviews/src/ktreewidgetsearchline.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/itemviews/src/kwidgetitemdelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/itemviews/src/kwidgetitemdelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/itemviews/src/kwidgetitemdelegate_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/itemviews/src/kwidgetitemdelegatepool.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/itemviews/src/kwidgetitemdelegatepool_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/itemviews/tests/CMakeLists.txt <span style="color: grey">(ef8182f)</span></li>
<li>staging/itemviews/tests/ktreewidgetsearchlinetest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/itemviews/tests/ktreewidgetsearchlinetest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/itemviews/tests/kwidgetitemdelegatetest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110845/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>