<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110482/">http://git.reviewboard.kde.org/r/110482/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110482/diff/8/?file=148765#file148765line31" style="color: black; font-weight: bold; text-decoration: underline;">staging/knotifications/src/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 8)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">31</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">configure_file</span><span class="p">(</span><span class="s">config-knotifications.h.cmake</span> <span class="o">${</span><span class="nv">CMAKE_CURRENT_BINARY_DIR</span><span class="o">}</span><span class="s">/config-knotifications.h</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is that .h.cmake file missing? I don't see it in git, and it's not in this review request either.</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On June 5th, 2013, 7:39 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated June 5, 2013, 7:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This implemets a step in the kdeui crumble epic.
moves the classes kstatusnotifieritem and knotificationsrestrictions in the knotifiactions library.
The patch works, but there are still several issues:
* porting from kdebug to qdebug loses the area number
* adds some link libraries: the classes add ki18n, kwidgets and KWidgetsAddons
* the test adds ki18n kde4support kdecore
* the KActionCollection becomes a qhash of actions: how should be kactioncollections ported?
I guess it should use the qt translation system, and redo the quit dialog to not usekstandardgui at all?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(cfa29ef)</span></li>
<li>kdeui/notifications/knotificationrestrictions.h <span style="color: grey">(7b83d25)</span></li>
<li>kdeui/notifications/knotificationrestrictions.cpp <span style="color: grey">(a396fd6)</span></li>
<li>kdeui/notifications/kstatusnotifieritem.h <span style="color: grey">(be21882)</span></li>
<li>kdeui/notifications/kstatusnotifieritem.cpp <span style="color: grey">(37abe7e)</span></li>
<li>kdeui/notifications/kstatusnotifieritemdbus_p.h <span style="color: grey">(063343c)</span></li>
<li>kdeui/notifications/kstatusnotifieritemdbus_p.cpp <span style="color: grey">(6c9e1da)</span></li>
<li>kdeui/notifications/kstatusnotifieritemprivate_p.h <span style="color: grey">(32e7906)</span></li>
<li>kdeui/notifications/org.freedesktop.Notifications.xml <span style="color: grey">(8ddb421)</span></li>
<li>kdeui/notifications/org.kde.StatusNotifierItem.xml <span style="color: grey">(82c427d)</span></li>
<li>kdeui/notifications/org.kde.StatusNotifierWatcher.xml <span style="color: grey">(dd45dc9)</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(cd055d5)</span></li>
<li>kdeui/tests/kstatusnotifieritemtest.h <span style="color: grey">(38a1e1a)</span></li>
<li>kdeui/tests/kstatusnotifieritemtest.cpp <span style="color: grey">(38e85ac)</span></li>
<li>staging/knotifications/src/CMakeLists.txt <span style="color: grey">(266b67c)</span></li>
<li>staging/knotifications/src/knotificationrestrictions.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/knotifications/src/knotificationrestrictions.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/knotifications/src/kstatusnotifieritem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/knotifications/src/kstatusnotifieritem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/knotifications/src/kstatusnotifieritemdbus_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/knotifications/src/kstatusnotifieritemdbus_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/knotifications/src/kstatusnotifieritemprivate_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/knotifications/src/org.freedesktop.Notifications.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/knotifications/src/org.kde.StatusNotifierItem.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/knotifications/src/org.kde.StatusNotifierWatcher.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/knotifications/tests/CMakeLists.txt <span style="color: grey">(2240a69)</span></li>
<li>staging/knotifications/tests/kstatusnotifieritemtest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/knotifications/tests/kstatusnotifieritemtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110482/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>