<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110733/">http://git.reviewboard.kde.org/r/110733/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110733/diff/1/?file=147058#file147058line28" style="color: black; font-weight: bold; text-decoration: underline;">staging/kiconthemes/src/kpixmapsequence.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">28</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <kiconloader.h></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah! No. What you mean is: you're wrong, David, it's actually used.
:-)
(what you suggest isn't valid C++; the caller has to see the default value)
Keep the #include then.</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On May 30th, 2013, 4:33 p.m. UTC, Wojciech Kapuscinski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Kevin Ottens.</div>
<div>By Wojciech Kapuscinski.</div>
<p style="color: grey;"><i>Updated May 30, 2013, 4:33 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">move kpixmapsequence, kpixmapsequenceoverlaypainter, kpixmapsequencewidget to KIconThemes
Note:
port kWarning to qWarning
removed unused #include <kdebug.h></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Build tested</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(d22f528)</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(881f8e5)</span></li>
<li>kdeui/tests/kpixmapsequenceoverlaypaintertest.h <span style="color: grey">(beb27d6)</span></li>
<li>kdeui/tests/kpixmapsequenceoverlaypaintertest.cpp <span style="color: grey">(0275fc7)</span></li>
<li>kdeui/util/kpixmapsequence.h <span style="color: grey">(5515fda)</span></li>
<li>kdeui/util/kpixmapsequence.cpp <span style="color: grey">(a31892f)</span></li>
<li>kdeui/util/kpixmapsequenceoverlaypainter.h <span style="color: grey">(723ac93)</span></li>
<li>kdeui/util/kpixmapsequenceoverlaypainter.cpp <span style="color: grey">(c67a018)</span></li>
<li>kdeui/util/kpixmapsequencewidget.h <span style="color: grey">(17c5be2)</span></li>
<li>kdeui/util/kpixmapsequencewidget.cpp <span style="color: grey">(37c4918)</span></li>
<li>staging/kiconthemes/src/CMakeLists.txt <span style="color: grey">(49e6b92)</span></li>
<li>staging/kiconthemes/src/kpixmapsequence.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kiconthemes/src/kpixmapsequence.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kiconthemes/src/kpixmapsequenceoverlaypainter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kiconthemes/src/kpixmapsequenceoverlaypainter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kiconthemes/src/kpixmapsequencewidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kiconthemes/src/kpixmapsequencewidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kiconthemes/tests/CMakeLists.txt <span style="color: grey">(06e9b57)</span></li>
<li>staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110733/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>