<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110418/">http://git.reviewboard.kde.org/r/110418/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Apar from the KConfigDialogManager issue below, it looks good. However, please wait until next week to commit it, to give people time to update their qt5.git build, since you use new API from there (QSpinBox::setDisplayIntegerBase). I promised Aaron that the use of new API in Qt would only happen after the first monday after the qt5 update.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110418/diff/2/?file=146814#file146814line146" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/dialogs/kconfigdialogmanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KConfigDialogManager::initMaps()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">146</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">s_changedMap</span><span class="p">()</span><span class="o">-></span><span class="n">insert</span><span class="p">(</span> <span class="s">"KIntNumInput"</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">valueChanged</span><span class="p">(</span><span class="kt">int</span><span class="p">)));</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do we need to register KIntNumInput into KConfigDialogManager "from the outside", i.e. from a Q_CONSTRUCTOR_FUNCTION in kintnuminput.cpp (kde4support)?
Otherwise existing code with KIntNumInput + KConfigDialogManager will break.
I think there were other commits to KConfigDialogManager earlier whicih might have the same issue. If there isn't one, we might need to add a public method for registering a class and its associated signal.</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On May 28th, 2013, 7:45 p.m. UTC, Anne-Marie Mahfouf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Kevin Ottens.</div>
<div>By Anne-Marie Mahfouf.</div>
<p style="color: grey;"><i>Updated May 28, 2013, 7:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move KNumInput to KDE4Support, use QSpinBox or QDoubleSpinBox instead.
Test moved as well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Build tested</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/dialogs/kconfigdialogmanager.cpp <span style="color: grey">(87c3e48)</span></li>
<li>kdeui/dialogs/kinputdialog.cpp <span style="color: grey">(6cbd881)</span></li>
<li>kdeui/dialogs/kinputdialog_p.h <span style="color: grey">(dcdff3f)</span></li>
<li>kdeui/tests/krulertest.h <span style="color: grey">(fc677c6)</span></li>
<li>kdeui/tests/krulertest.cpp <span style="color: grey">(9686421)</span></li>
<li>staging/kde4support/src/kdeui/kcolordialog.cpp <span style="color: grey">(041c06a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110418/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>