<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110643/">http://git.reviewboard.kde.org/r/110643/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 25th, 2013, 5:17 p.m. UTC, <b>David Gil Oliva</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110643/diff/1/?file=146196#file146196line346" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/dialogs/kpassworddialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KPasswordDialog::setKnownLogins( const QMap<QString, QString>& knownLogins )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">345</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">userEditCombo</span> <span class="o">=</span> <span class="k">new</span> <span class="n"><span class="hl">K</span>ComboBox</span><span class="p">(</span> <span class="nb">t<span class="hl">rue</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="k"><span class="hl">t</span>his</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">342</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">userEditCombo</span> <span class="o">=</span> <span class="k">new</span> <span class="n"><span class="hl">Q</span>ComboBox</span><span class="p">(</span> <span class="k">this</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sometimes there are spaces around parentheses, sometimes there is only one space and sometimes there's none. Style should be uniform. What's the preferred? (Mine is no spaces)</pre>
</blockquote>
<p>On May 25th, 2013, 5:25 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">My preference is no spaces too, but I tried to follow the style already in this file which seemed to have spaces</pre>
</blockquote>
<p>On May 27th, 2013, 10:05 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This isn't about personal preference, however :)
When touching lines of code for other reasons, please adapt them to the kdelibs coding style. Which is indeed no spaces inside parenthesis. http://techbase.kde.org/Policies/Kdelibs_Coding_Style</pre>
</blockquote>
<p>On May 27th, 2013, 2:45 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To clarify in simple terms for me.
When we modify a file for frameworks porting should we copy the style already used, use kdelibs coding style on lines we edit, or adjust the whole thing?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use kdelibs coding style on lines that you edit.</pre>
<br />
<p>- David</p>
<br />
<p>On May 25th, 2013, 12:57 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated May 25, 2013, 12:57 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Known "bugs"
- there's no clear icon in the text field anymore as I had to port away from KLineEdit
Diff shown is without the actual moving for easier reviewing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(cfa29ef)</span></li>
<li>kdeui/dialogs/kpassworddialog.h <span style="color: grey">(e554c2a)</span></li>
<li>kdeui/dialogs/kpassworddialog.cpp <span style="color: grey">(168271c)</span></li>
<li>kdeui/dialogs/kpassworddialog.ui <span style="color: grey">(95845b9)</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(cd055d5)</span></li>
<li>kdeui/tests/kpassworddialogtest.cpp <span style="color: grey">(b1c55ee)</span></li>
<li>tier1/kwidgetsaddons/src/CMakeLists.txt <span style="color: grey">(df22699)</span></li>
<li>tier1/kwidgetsaddons/tests/CMakeLists.txt <span style="color: grey">(de5e6e4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110643/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>