<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110477/">http://git.reviewboard.kde.org/r/110477/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110477/diff/1/?file=144374#file144374line17" style="color: black; font-weight: bold; text-decoration: underline;">staging/kde4attic/tests/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">17</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="err">ktimecomboboxtest</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should go in autotests, not tests.
We have autotests folders for the unit tests, and tests folders for the manual tests.</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On May 16th, 2013, 6:28 p.m. UTC, Anne-Marie Mahfouf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Kevin Ottens.</div>
<div>By Anne-Marie Mahfouf.</div>
<p style="color: grey;"><i>Updated May 16, 2013, 6:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move KTimeComboBox to KDE4Attic
Move test: it was in KDEUI Unit Tests but there's no such section in the staging/kde4attic/tests/CMakeLists.txt so it's now in executable which might be wrong.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It builds</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(cfa29ef)</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(cd055d5)</span></li>
<li>kdeui/tests/ktimecomboboxtest.h <span style="color: grey">(793bffb)</span></li>
<li>kdeui/tests/ktimecomboboxtest.cpp <span style="color: grey">(4aaadef)</span></li>
<li>kdeui/widgets/ktimecombobox.h <span style="color: grey">(21094b2)</span></li>
<li>kdeui/widgets/ktimecombobox.cpp <span style="color: grey">(e1a9322)</span></li>
<li>kdewidgets/kde.widgets <span style="color: grey">(aa07c0f)</span></li>
<li>kdewidgets/kdedeprecated.widgets <span style="color: grey">(3adc0b2)</span></li>
<li>staging/kde4attic/src/CMakeLists.txt <span style="color: grey">(2fe1b8c)</span></li>
<li>staging/kde4attic/src/ktimecombobox.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4attic/src/ktimecombobox.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4attic/tests/CMakeLists.txt <span style="color: grey">(1305d63)</span></li>
<li>staging/kde4attic/tests/ktimecomboboxtest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4attic/tests/ktimecomboboxtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110477/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>