<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110482/">http://git.reviewboard.kde.org/r/110482/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think it's taking the right direction. Probably good to get rid of ki18n if we don't use any of its advanced features (I don't think we do). As for kwidgets and kwidgetsaddons, it depends a bit on the aim we have for that library and which tier we want for it. If we aim tier1 it can't depend on them, if we aim tier2 it can depend on kwidgetsaddons, if we aim tier3 it can depend on both.
Any idea why it requires KWidgets and KWidgetsAddons?
Test should be streamlined to bring less dependencies too.</pre>
<br />
<p>- Kevin</p>
<br />
<p>On May 18th, 2013, 3:27 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated May 18, 2013, 3:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This implemets a step in the kdeui crumble epic.
moves the classes kstatusnotifieritem and knotificationsrestrictions in the knotifiactions library.
The patch works, but there are still several issues:
* porting from kdebug to qdebug loses the area number
* adds some link libraries: the classes add ki18n, kwidgets and KWidgetsAddons
* the test adds ki18n kde4support kdecore
* the KActionCollection becomes a qhash of actions: how should be kactioncollections ported?
I guess it should use the qt translation system, and redo the quit dialog to not usekstandardgui at all?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(cfa29ef)</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(cd055d5)</span></li>
<li>staging/knotifications/src/CMakeLists.txt <span style="color: grey">(266b67c)</span></li>
<li>staging/knotifications/src/knotificationrestrictions.cpp <span style="color: grey">(a396fd6)</span></li>
<li>staging/knotifications/src/kstatusnotifieritem.h <span style="color: grey">(be21882)</span></li>
<li>staging/knotifications/src/kstatusnotifieritem.cpp <span style="color: grey">(37abe7e)</span></li>
<li>staging/knotifications/src/kstatusnotifieritemdbus_p.cpp <span style="color: grey">(6c9e1da)</span></li>
<li>staging/knotifications/src/kstatusnotifieritemprivate_p.h <span style="color: grey">(32e7906)</span></li>
<li>staging/knotifications/tests/CMakeLists.txt <span style="color: grey">(2240a69)</span></li>
<li>staging/knotifications/tests/kstatusnotifieritemtest.cpp <span style="color: grey">(38e85ac)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110482/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>