<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110540/">http://git.reviewboard.kde.org/r/110540/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit ee222241fc381c2794ad725d86caf85b4cba8893 by Alex Merry to branch frameworks.</pre>
<br />
<p>- Commit</p>
<br />
<p>On May 20th, 2013, 10:40 a.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated May 20, 2013, 10:40 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move KAccelGen and kaccelgentest to KDE4Support
Not used anywhere else in kdelibs.
I didn't put a porting comment into the apidocs, because (a) I wasn't entirely certain what the porting strategy should be, and (b) lxr.kde.org suggests that in practice "don't be konqueror" is a good porting strategy.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still builds, tests still run (and the same ones seem to pass as before, including kaccelgentest).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(cfa29ef)</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(cd055d5)</span></li>
<li>kdeui/tests/kaccelgentest.cpp <span style="color: grey">(24afd07)</span></li>
<li>kdeui/util/kaccelgen.h <span style="color: grey">(a7decd7)</span></li>
<li>staging/kde4support/autotests/CMakeLists.txt <span style="color: grey">(b61c8f3)</span></li>
<li>staging/kde4support/autotests/kaccelgentest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(a8e0a0c)</span></li>
<li>staging/kde4support/src/kdeui/kaccelgen.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110540/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>