<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109503/">http://git.reviewboard.kde.org/r/109503/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 15th, 2013, 5:07 p.m. UTC, <b>Stephen Kelly</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The problem is that build.kde.org uses qt5.git, which does not yet have that commit. Actually qt5.git hasn't been updated in 6 weeks: https://codereview.qt-project.org/#change,46445
If b.k.o can be updated to use the dev branches of the qt 5 submodules, I think that's a good idea. In general, I think it's a bad idea to use qt5.git or to recommend anyone else use it (as is currently recommended on the wiki).
At any rate, this patch shouldn't go in until b.k.o can build it.</pre>
</blockquote>
<p>On March 15th, 2013, 7:25 p.m. UTC, <b>Ben Cooksley</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Easier said than done. build.kde.org uses a separate install prefix for each project it builds.
Somehow I suspect the Qt5 CMake system would shatter if it was asked to install each Qt5 submodule into it's own prefix.
Not to mention that it would make updating Qt5 on build.kde.org a royal PITA because you would have to run the module builds in their precise upstream dependency order (in case of incompatibilites) which Jenkins isn't really designed for (from what I have seen in it's interface so far at least). It would also mean maintaining a list of their modules on build.kde.org.
Is there any good reason why the Qt developers are dragging the chain and not updating qt5.git? Obviously the individual modules build fine...</pre>
</blockquote>
<p>On March 15th, 2013, 8:26 p.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">qt5.git is behind because of unstability of the Qt CI. This is being worked on, I don't think we should change anything on our side.
You can track progress at https://codereview.qt-project.org/46445</pre>
</blockquote>
<p>On March 15th, 2013, 8:31 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, this means that our code is uncompilable if one follows the instructions on how to compile it, but i guess we are ok with that.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a slight simplification of the problem... the instructions do say "use qt5.git". The other solution (use qtbase+qtsvg+qtx11extras only) is already documented as suboptimal (not enough for plasma-framework, which we should at least check compiles when making API changes in kdelibs).
Fixed: added a note to the instructions ("git checkout 90361fd in qtbase").</pre>
<br />
<p>- David</p>
<br />
<p>On March 15th, 2013, 4:59 p.m. UTC, Albert Astals Cid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated March 15, 2013, 4:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">34a3f2cd442ff1396e508f7a8890b968f1bb3179 has been merged to qtbase and now frameworks contains definitions of functions that clash with the ones from Qt itself</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/tests/kdatetimetest.cpp <span style="color: grey">(d64492b)</span></li>
<li>libkdeqt5staging/src/CMakeLists.txt <span style="color: grey">(6572b92)</span></li>
<li>libkdeqt5staging/src/qtest_staging.h <span style="color: grey">(c2b081e)</span></li>
<li>staging/kde4support/src/kdecore/qtest_kde.h <span style="color: grey">(7174893)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109503/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>