<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109451/">http://git.reviewboard.kde.org/r/109451/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated March 13, 2013, 6:45 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixx11h is a header which is mostly needed by KWindowSystem and in
general by functionality using XLib. Because of that it makes more
sense to have the header together with other X related headers in
KWindowSystem.
At the same time the HAVE_X11 ifdef is dropped from the header. This
is not needed as the header is only intended to be used if XLib is
included. The check is moved to the user of the header which in most
has the #include already in an #ifdef HAVE_X11 block.
More information in [1].
[1]: http://lists.kde.org/?l=kde-frameworks-devel&m=136298982111644&w=2</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">clean compile and install of frameworks</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kded/CMakeLists.txt <span style="color: grey">(f51b7db)</span></li>
<li>kdeui/CMakeLists.txt <span style="color: grey">(42bd230)</span></li>
<li>kdeui/dialogs/kcupsoptionswidget_p.cpp <span style="color: grey">(4be2276)</span></li>
<li>kdeui/dialogs/kdeprintdialog.cpp <span style="color: grey">(4f1c8b7)</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(a6ebae1)</span></li>
<li>kdeui/tests/fixx11h_test.cpp <span style="color: grey">(5d3e467)</span></li>
<li>kdeui/tests/fixx11h_test2.cpp <span style="color: grey">(d01999b)</span></li>
<li>kdeui/util/fixx11h.h <span style="color: grey">(77da0f8)</span></li>
<li>kfile/CMakeLists.txt <span style="color: grey">(0f84995)</span></li>
<li>kfile/kurlnavigator.cpp <span style="color: grey">(e54e14f)</span></li>
<li>khtml/CMakeLists.txt <span style="color: grey">(9c791cb)</span></li>
<li>khtml/test_regression_fontoverload.cpp <span style="color: grey">(0492b63)</span></li>
<li>kinit/CMakeLists.txt <span style="color: grey">(8f6fb06)</span></li>
<li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(13a042b)</span></li>
<li>tier1/kwindowsystem/autotests/CMakeLists.txt <span style="color: grey">(e2a7f0c)</span></li>
<li>tier1/kwindowsystem/autotests/fixx11h_test.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kwindowsystem/autotests/fixx11h_test2.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kwindowsystem/src/CMakeLists.txt <span style="color: grey">(41c40bb)</span></li>
<li>tier1/kwindowsystem/src/fixx11h.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kwindowsystem/src/fixx11h_p.h <span style="color: grey">(79c73a0)</span></li>
<li>tier1/kwindowsystem/src/kwindowsystem_x11.cpp <span style="color: grey">(bd608ac)</span></li>
<li>tier1/kwindowsystem/src/netwm.h <span style="color: grey">(d309606)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109451/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>