<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109019/">http://git.reviewboard.kde.org/r/109019/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114639#file114639line245" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/actions/kaction.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">243</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">enum</span> <span class="n">GlobalShortcutLoading</span> <span class="p">{</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please don't remove this enum from KAction, it should really be a copy to KGlobalAccel not a move as we try to maintain KAction source compatibility.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114639#file114639line421" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/actions/kaction.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">419</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">GlobalShortcutLoading</span> <span class="n">loading</span> <span class="o">=</span> <span class="n">Autoloading</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">408</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">KGlobalAccel</span></span><span class="o"><span class="hl">::</span></span><span class="n">GlobalShortcutLoading</span> <span class="n">loading</span> <span class="o">=</span> <span class="n"><span class="hl">KGlobalAccel</span></span><span class="o"><span class="hl">::</span></span><span class="n">Autoloading</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Of course means this one should go back to use KAction's enum.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114639#file114639line441" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/actions/kaction.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">439</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KDEUI_DEPRECATED</span> <span class="kt">void</span> <span class="nf">setGlobalShortcutAllowed</span><span class="p">(</span><span class="kt">bool</span> <span class="n">allowed</span><span class="p">,</span> <span class="n">GlobalShortcutLoading</span> <span class="n">loading</span> <span class="o">=</span> <span class="n">Autoloading</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">428</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KDEUI_DEPRECATED</span> <span class="kt">void</span> <span class="nf">setGlobalShortcutAllowed</span><span class="p">(</span><span class="kt">bool</span> <span class="n">allowed</span><span class="p">,</span> <span class="n"><span class="hl">KGlobalAccel</span></span><span class="o"><span class="hl">::</span></span><span class="n">GlobalShortcutLoading</span> <span class="n">loading</span> <span class="o">=</span> <span class="n"><span class="hl">KGlobalAccel</span></span><span class="o"><span class="hl">::</span></span><span class="n">Autoloading</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">And this one too.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114641#file114641line24" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/actions/kaction_p.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">24</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include "kauthaction.h"</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why this include? Probably unnecessary, you didn't introduce a KAuthAction use there AFAICT.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114642#file114642line419" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/actions/kactioncollection.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KActionCollection::importGlobalShortcuts( KConfigGroup* config )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">419</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">kaction</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span> <span class="n">KShortcut</span><span class="p">(</span><span class="n">entry</span><span class="p">),</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">Action</span></span><span class="o">::</span><span class="n">NoAutoloading</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">419</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">kaction</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span> <span class="n">KShortcut</span><span class="p">(</span><span class="n">entry</span><span class="p">),</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">GlobalAccel</span></span><span class="o">::</span><span class="n">NoAutoloading</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unnecessary change if you keep the enum in KAction.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114642#file114642line421" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/actions/kactioncollection.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KActionCollection::importGlobalShortcuts( KConfigGroup* config )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">421</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">kaction</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span> <span class="n">kaction</span><span class="o">-></span><span class="n">shortcut</span><span class="p">(</span><span class="n">KAction</span><span class="o">::</span><span class="n">DefaultShortcut</span><span class="p">),</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">Action</span></span><span class="o">::</span><span class="n">NoAutoloading</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">421</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">kaction</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span> <span class="n">kaction</span><span class="o">-></span><span class="n">shortcut</span><span class="p">(</span><span class="n">KAction</span><span class="o">::</span><span class="n">DefaultShortcut</span><span class="p">),</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">GlobalAccel</span></span><span class="o">::</span><span class="n">NoAutoloading</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unnecessary change if you keep the enum in KAction.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114643#file114643line229" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/dialogs/kshortcutseditoritem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KShortcutsEditorItem::setKeySequence(uint column, const QKeySequence &seq)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">229</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_action</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span><span class="n">ks</span><span class="p">,</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">Action</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">229</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_action</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span><span class="n">ks</span><span class="p">,</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">GlobalAccel</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unnecessary change if you keep the enum in KAction.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114643#file114643line328" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/dialogs/kshortcutseditoritem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KShortcutsEditorItem::undo()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">328</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">K<span class="hl">Action</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">328</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">K<span class="hl">GlobalAccel</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unnecessary change if you keep the enum in KAction.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114644#file114644line180" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/shortcuts/kglobalaccel.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">179</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">bool</span> <span class="nf">setDefaultShortcut</span><span class="p">(</span><span class="n">KAction</span> <span class="o">*</span><span class="n">action</span><span class="p">,</span> <span class="k">const</span> <span class="n">KShortcut</span> <span class="o">&</span><span class="n">shortcut</span><span class="p">,</span> <span class="n">GlobalShortcutLoading</span> <span class="n">loadFlag</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please add apidox for those methods, don't forget the @since 5.0.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114644#file114644line267" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/shortcuts/kglobalaccel.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">266</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">globalShortcutChanged</span><span class="p">(</span><span class="k">const</span> <span class="n">QKeySequence</span><span class="o">&</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm... I'm wondering, should this signal have a twin (both emitted at the same time) where we indicate the action linked to the shortcut when it changed?
The old one being tied to KAction we had that information (knew the emitter), here the information is lost.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114645#file114645line426" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/shortcuts/kglobalaccel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KGlobalAccelPrivate::_k_invokeAction(</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">419</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KAction</span> <span class="o">*</span><span class="n">action</span> <span class="o">=</span> <span class="mi">0</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">425</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="hl"> </span><span class="k"><span class="hl">const</span></span> <span class="n">KAction</span> <span class="o">*</span><span class="n">action</span> <span class="o">=</span> <span class="mi">0</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Drop the const, it's obviously not const since you'r forced to use a const_cast later on...</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114646#file114646line78" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/shortcuts/kglobalaccel_p.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">76</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QMultiHash</span><span class="o"><</span><span class="n">QString</span><span class="p">,</span> <span class="n">KAction</span> <span class="o">*></span> <span class="n">nameToAction</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">77</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QMultiHash</span><span class="o"><</span><span class="n">QString</span><span class="p">,</span><span class="hl"> </span><span class="k"><span class="hl">const</span></span> <span class="n">KAction</span> <span class="o">*></span> <span class="n">nameToAction</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should not be const as you call non const methods on instances of KAction stored there.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114647#file114647line84" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/tests/kglobalshortcuttest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KGlobalShortcutTest::setupTest(QString id)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">84</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">K<span class="hl">Action</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">84</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">K<span class="hl">GlobalAccel</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unnecessary change if you keep the enum in KAction.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114647#file114647line91" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/tests/kglobalshortcuttest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KGlobalShortcutTest::setupTest(QString id)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">91</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">K<span class="hl">Action</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">91</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">K<span class="hl">GlobalAccel</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unnecessary change if you keep the enum in KAction.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114647#file114647line154" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/tests/kglobalshortcuttest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KGlobalShortcutTest::testChangeShortcut()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">154</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_actionA</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span><span class="n">newCutA</span><span class="p">,</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">Action</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">154</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_actionA</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span><span class="n">newCutA</span><span class="p">,</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">GlobalAccel</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unnecessary change if you keep the enum in KAction.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114647#file114647line163" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/tests/kglobalshortcuttest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KGlobalShortcutTest::testChangeShortcut()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">163</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_actionB</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span><span class="n">cutB</span><span class="p">,</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">Action</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">163</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_actionB</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span><span class="n">cutB</span><span class="p">,</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">GlobalAccel</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unnecessary change if you keep the enum in KAction.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114647#file114647line173" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/tests/kglobalshortcuttest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KGlobalShortcutTest::testChangeShortcut()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">173</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_actionB</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span><span class="n">cutB</span><span class="p">,</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">Action</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">173</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_actionB</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span><span class="n">cutB</span><span class="p">,</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">GlobalAccel</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unnecessary change if you keep the enum in KAction.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114647#file114647line282" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/tests/kglobalshortcuttest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KGlobalShortcutTest::testComponentAssignment()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">282</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">action</span><span class="p">.</span><span class="n">setGlobalShortcut</span><span class="p">(</span><span class="n">cutB</span><span class="p">,</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">Action</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">282</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">action</span><span class="p">.</span><span class="n">setGlobalShortcut</span><span class="p">(</span><span class="n">cutB</span><span class="p">,</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">GlobalAccel</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unnecessary change if you keep the enum in KAction.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114647#file114647line293" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/tests/kglobalshortcuttest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KGlobalShortcutTest::testComponentAssignment()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">293</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">action</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span><span class="n">cutB</span><span class="p">,</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">Action</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">293</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">action</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span><span class="n">cutB</span><span class="p">,</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">GlobalAccel</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unnecessary change if you keep the enum in KAction.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114647#file114647line336" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/tests/kglobalshortcuttest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KGlobalShortcutTest::testOverrideMainComponentData()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">336</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">action</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span><span class="n">cutB</span><span class="p">,</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">Action</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">336</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">action</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span><span class="n">cutB</span><span class="p">,</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">GlobalAccel</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unnecessary change if you keep the enum in KAction.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114647#file114647line344" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/tests/kglobalshortcuttest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KGlobalShortcutTest::testOverrideMainComponentData()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">344</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">action</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span><span class="n">cutB</span><span class="p">,</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">Action</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">344</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">action</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span><span class="n">cutB</span><span class="p">,</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">GlobalAccel</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unnecessary change if you keep the enum in KAction.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114647#file114647line363" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/tests/kglobalshortcuttest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KGlobalShortcutTest::testOverrideMainComponentData()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">363</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">action</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span><span class="n">cutB</span><span class="p">,</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">Action</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">363</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">action</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span><span class="n">cutB</span><span class="p">,</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">GlobalAccel</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unnecessary change if you keep the enum in KAction.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114647#file114647line374" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/tests/kglobalshortcuttest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KGlobalShortcutTest::testOverrideMainComponentData()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">374</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">action</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span><span class="n">cutB</span><span class="p">,</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">Action</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">374</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">action</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span><span class="n">cutB</span><span class="p">,</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">GlobalAccel</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unnecessary change if you keep the enum in KAction.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109019/diff/2/?file=114647#file114647line393" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/tests/kglobalshortcuttest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KGlobalShortcutTest::testNotification()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">393</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">action</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span><span class="n">cutB</span><span class="p">,</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">Action</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">393</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">action</span><span class="o">-></span><span class="n">setGlobalShortcut</span><span class="p">(</span><span class="n">cutB</span><span class="p">,</span> <span class="n">KAction</span><span class="o">::</span><span class="n">ActiveShortcut</span><span class="p">,</span> <span class="n">K<span class="hl">GlobalAccel</span></span><span class="o">::</span><span class="n">NoAutoloading</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unnecessary change if you keep the enum in KAction.</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On February 20th, 2013, 10:32 p.m. UTC, Valentin Rusu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Kevin Ottens.</div>
<div>By Valentin Rusu.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2013, 10:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KDELibs cleanup task: move global shortcut facilities from KAction to KGlobalAccel. The second step, registering QActions instead of KActions, will be done after completing this review.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Code compiles</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/tests/kglobalshortcuttest.cpp <span style="color: grey">(49fb8ec)</span></li>
<li>kdeui/actions/kaction.h <span style="color: grey">(ddaa4de)</span></li>
<li>kdeui/actions/kaction.cpp <span style="color: grey">(ec63a72)</span></li>
<li>kdeui/actions/kaction_p.h <span style="color: grey">(b50e678)</span></li>
<li>kdeui/actions/kactioncollection.cpp <span style="color: grey">(555b204)</span></li>
<li>kdeui/dialogs/kshortcutseditoritem.cpp <span style="color: grey">(5aa8437)</span></li>
<li>kdeui/shortcuts/kglobalaccel.h <span style="color: grey">(ed68bba)</span></li>
<li>kdeui/shortcuts/kglobalaccel.cpp <span style="color: grey">(36dbab7)</span></li>
<li>kdeui/shortcuts/kglobalaccel_p.h <span style="color: grey">(04feaba)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109019/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>