<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109056/">http://git.reviewboard.kde.org/r/109056/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alexander Richardson.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">remove KCoreConfigSkeleton::ItemEnum::Choice2
The obsolete Choice struct was removed, Choice2 has been renamed to Choice and Choice2 has been made a deprecated typedef.
Should the deprecated version stay, or should it be removed? I don't think many people use this. According to http://lxr.kde.org/ident?i=Choice2 there are only two uses in kdepim</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">build works, kconfig unit test work</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/tests/kconfigdialog_unittest.cpp <span style="color: grey">(4f1a7a7d65aa08de29a8745ebc9cd7507bcb283d)</span></li>
<li>tier2/kconfig/autotests/kconfig_compiler/test1.cpp.ref <span style="color: grey">(2f2977c160d83360aabb62bf36438b76aa61fb58)</span></li>
<li>tier2/kconfig/autotests/kconfig_compiler/test11.cpp.ref <span style="color: grey">(6daf86664aadd307d111be86c32db3bb74ef309f)</span></li>
<li>tier2/kconfig/autotests/kconfig_compiler/test11a.cpp.ref <span style="color: grey">(a0378a407c290a775c16fe9b8877fe298e2d456c)</span></li>
<li>tier2/kconfig/autotests/kconfig_compiler/test2.cpp.ref <span style="color: grey">(447e837775336ca3d74c34f2506998dd293b74dd)</span></li>
<li>tier2/kconfig/autotests/kconfig_compiler/test4.cpp.ref <span style="color: grey">(6f304738bdef675a92317b37ae682e803094ddde)</span></li>
<li>tier2/kconfig/autotests/kconfig_compiler/test5.cpp.ref <span style="color: grey">(af458e6152179eccbb2015ded995cb1237f0ff0a)</span></li>
<li>tier2/kconfig/autotests/kconfig_compiler/test_dpointer.cpp.ref <span style="color: grey">(6aa770197c4f1a6b6f203c03443c8d539f387fec)</span></li>
<li>tier2/kconfig/src/core/kcoreconfigskeleton.h <span style="color: grey">(5dc9e804d46651e052d53cff2a306f3b909604c5)</span></li>
<li>tier2/kconfig/src/core/kcoreconfigskeleton.cpp <span style="color: grey">(aff4d4766a82509865459a85aa2928159b52f671)</span></li>
<li>tier2/kconfig/src/kconfig_compiler/kconfig_compiler.cpp <span style="color: grey">(60a8873e1017f9af759e6561ae1acc8c1e9b3f10)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109056/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>