<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109019/">http://git.reviewboard.kde.org/r/109019/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Kevin Ottens.</div>
<div>By Valentin Rusu.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2013, 10:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Here is the updated patch. I solved many of the issues you shown.
I also moved the globalShortcutChanged signal from KAction to KGlobalAccel.
Several issues was centered around the const KAction* semantics of KGlobalAccel's methods. Letting alone that current code also had these const qualifiers, this new KGlobalAccel implementation no longer modifies KAction state. This should be clearly stated in our API using this const qualifier. So I prefered to (gently "sauf respect") drop these issues. :-)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KDELibs cleanup task: move global shortcut facilities from KAction to KGlobalAccel. The second step, registering QActions instead of KActions, will be done after completing this review.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Code compiles</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/tests/kglobalshortcuttest.cpp <span style="color: grey">(49fb8ec)</span></li>
<li>kdeui/actions/kaction.h <span style="color: grey">(ddaa4de)</span></li>
<li>kdeui/actions/kaction.cpp <span style="color: grey">(ec63a72)</span></li>
<li>kdeui/actions/kaction_p.h <span style="color: grey">(b50e678)</span></li>
<li>kdeui/actions/kactioncollection.cpp <span style="color: grey">(555b204)</span></li>
<li>kdeui/dialogs/kshortcutseditoritem.cpp <span style="color: grey">(5aa8437)</span></li>
<li>kdeui/shortcuts/kglobalaccel.h <span style="color: grey">(ed68bba)</span></li>
<li>kdeui/shortcuts/kglobalaccel.cpp <span style="color: grey">(36dbab7)</span></li>
<li>kdeui/shortcuts/kglobalaccel_p.h <span style="color: grey">(04feaba)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109019/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>