<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108495/">http://git.reviewboard.kde.org/r/108495/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 21st, 2013, 12:38 p.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Excellent work. Two questions:
1) did you get a chance to test at least one of these plugins, e.g. with a test program that uses QImage to load a file (I don't know if we have one already)?
2) did you check whether Qt already supports has some of these? The kimgio code is very old, and if Qt supports some of these files [correctly] then we might want to avoid the duplication and get rid of the corresponding kimgio plugins.
Thanks!</pre>
</blockquote>
<p>On January 21st, 2013, 1:05 p.m. UTC, <b>Jon Severinsson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1) Unfortunately no, someone should probably add one as a test case...
2) I hadn't. As far as I can tell, Qt supports bmp, png, ppm, xbm, xpm (in libQt5Gui.so) gif, ico, jpeg (qtbase plugins), svg (qtsvg plugin), mng, tga, tiff, wbmp (qtimageformats plugins). That would make our tga plugin the only duplicate work. I'll remove it before pushing.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Qt's TGA plugin is read-only in Qt 4.x, did that change for 5.x?</pre>
<br />
<p>- Christoph</p>
<br />
<p>On January 21st, 2013, 12:20 p.m. UTC, Jon Severinsson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Jon Severinsson.</div>
<p style="color: grey;"><i>Updated Jan. 21, 2013, 12:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Complete port of all kimgio to Qt5, including the json metadata and some minor code cleanup.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(0a67fe8)</span></li>
<li>kimgio/CMakeLists.txt <span style="color: grey">(2e4f20e)</span></li>
<li>kimgio/dds.h <span style="color: grey">(4c269ce)</span></li>
<li>kimgio/dds.cpp <span style="color: grey">(0090703)</span></li>
<li>kimgio/dds.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>kimgio/eps.h <span style="color: grey">(0f01310)</span></li>
<li>kimgio/eps.cpp <span style="color: grey">(c3e6f1d)</span></li>
<li>kimgio/eps.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>kimgio/exr.h <span style="color: grey">(fa7e646)</span></li>
<li>kimgio/exr.cpp <span style="color: grey">(7361ac4)</span></li>
<li>kimgio/exr.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>kimgio/jp2.h <span style="color: grey">(4daffcc)</span></li>
<li>kimgio/jp2.cpp <span style="color: grey">(b28c2a2)</span></li>
<li>kimgio/jp2.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>kimgio/pcx.h <span style="color: grey">(57059e7)</span></li>
<li>kimgio/pcx.cpp <span style="color: grey">(4237966)</span></li>
<li>kimgio/pcx.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>kimgio/pic.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kimgio/pic.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kimgio/pic.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>kimgio/pic_io_handler.h <span style="color: grey">(e81ec19)</span></li>
<li>kimgio/pic_io_handler.cpp <span style="color: grey">(b2e7c1d)</span></li>
<li>kimgio/pic_io_plugin.h <span style="color: grey">(1701b27)</span></li>
<li>kimgio/pic_io_plugin.cpp <span style="color: grey">(3328d24)</span></li>
<li>kimgio/psd.h <span style="color: grey">(606d2de)</span></li>
<li>kimgio/psd.cpp <span style="color: grey">(52dcebf)</span></li>
<li>kimgio/psd.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>kimgio/ras.h <span style="color: grey">(7603185)</span></li>
<li>kimgio/ras.cpp <span style="color: grey">(f056c54)</span></li>
<li>kimgio/ras.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>kimgio/rgb.h <span style="color: grey">(9c41190)</span></li>
<li>kimgio/rgb.cpp <span style="color: grey">(49b500f)</span></li>
<li>kimgio/rgb.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>kimgio/tga.h <span style="color: grey">(6421e9e)</span></li>
<li>kimgio/tga.cpp <span style="color: grey">(c6f1599)</span></li>
<li>kimgio/tga.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>kimgio/xcf.h <span style="color: grey">(ffdc0f0)</span></li>
<li>kimgio/xcf.cpp <span style="color: grey">(2b782be)</span></li>
<li>kimgio/xcf.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>kimgio/xview.h <span style="color: grey">(7ae9a2c)</span></li>
<li>kimgio/xview.cpp <span style="color: grey">(960bc22)</span></li>
<li>kimgio/xview.json <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108495/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>