<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108449/">http://git.reviewboard.kde.org/r/108449/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is essentially a small subset of my review 108263. I see nothing wrong with it, but I think it is unnecessary as we could just push my more extensive patch directly instead.
That said, I see no problem in rebasing my patch on top of this, so if you are uncomfortable with the size of my patch, feel free to push this one for the time being.</pre>
<br />
<p>- Jon</p>
<br />
<p>On January 17th, 2013, 4:27 p.m. UTC, Kevin Ottens wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure, John Layt, and Jon Severinsson.</div>
<div>By Kevin Ottens.</div>
<p style="color: grey;"><i>Updated Jan. 17, 2013, 4:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adjust to Julian Day computation in Qt5's QDate
Qt5 uses a new algorithm for deal with julian days so adjust
KCalendarSystem to it. Because of that change, January 1st -4712 is not
a wednesday anymore but a saturday, so one of the cases for ISO Week
date is not testable anymore (hence adjustment in tests).
It finally makes kcalendartest pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All kdelibs/frameworks unit tests pass when built against Qt5 dev.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/date/kcalendarsystemqdate.cpp <span style="color: grey">(f07e93b1ac87b1081cffe0702370cfe0048837c2)</span></li>
<li>kdecore/tests/kcalendartest.cpp <span style="color: grey">(c6077206ac7772f8356f93f680c203fa58ba06fa)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108449/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>