<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107688/">http://git.reviewboard.kde.org/r/107688/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 13th, 2012, 9:01 a.m., <b>John Layt</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I personally don't see the need for this. It's not making things faster, and restricting future options. Changing the public api method from virtual to inline is not very future-proof.
On the whole virtual vs inline thing, I need to email the list with some history about this.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The "need" is maintainable code. The current week system code in QCalendarSystem is a mess, and contains special casing that does the exact thing but slower (eg HewbrewCalendarSystem that). Of course, if we keep daysInWeek() non-deprecated and non-inline, this function shouldn't be inline either, but come with the same big fat warning.</pre>
<br />
<p>- Jon</p>
<br />
<p>On December 13th, 2012, 7:41 a.m., Jon Severinsson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Jon Severinsson.</div>
<p style="color: grey;"><i>Updated Dec. 13, 2012, 7:41 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Day of week is the same for a given julian day number regardless of calendar system used.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/date/kcalendarsystem.h <span style="color: grey">(efddd08)</span></li>
<li>kdecore/date/kcalendarsystem.cpp <span style="color: grey">(1aed791)</span></li>
<li>kdecore/date/kcalendarsystemhebrew.cpp <span style="color: grey">(e3d1484)</span></li>
<li>kdecore/date/kcalendarsystemhebrew_p.h <span style="color: grey">(75a6280)</span></li>
<li>kdecore/date/kcalendarsystemprivate_p.h <span style="color: grey">(d935ead)</span></li>
<li>kdecore/date/kcalendarsystemqdate.cpp <span style="color: grey">(f233d219)</span></li>
<li>kdecore/date/kcalendarsystemqdate_p.h <span style="color: grey">(9363fff)</span></li>
<li>kdecore/tests/kcalendartest.h <span style="color: grey">(505c137)</span></li>
<li>kdecore/tests/kcalendartest.cpp <span style="color: grey">(85d790d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107688/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>