<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107696/">http://git.reviewboard.kde.org/r/107696/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No. This is very very wrong. Week day name *does* depend on both calendar and language, as does month name. This is for a very specific and widely used case for religious calendars in particular where they are used in parallel with the Gregorian. This scheme was worked out carefully with various user groups in different countries and the translation teams to allow maximum flexibility for each translation team to decide what the common usage is in their language and country.</pre>
<br />
<p>- John</p>
<br />
<p>On December 13th, 2012, 7:43 a.m., Jon Severinsson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Jon Severinsson.</div>
<p style="color: grey;"><i>Updated Dec. 13, 2012, 7:43 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Weekday names depend on *lanuage*, not calendar system. The usual ki18nc
can handle it just fine, so consolidate it all to a single function.
Note: Between patch 3 and 4 in this series I'm moving some functions to a new file "kcalendarsystemweek.cpp" in order move to out ouf the way of regular calendar system code. That commit changes no code whatsoever, so don't really need a review.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/date/kcalendarsystem.h <span style="color: grey">(efddd08)</span></li>
<li>kdecore/date/kcalendarsystem.cpp <span style="color: grey">(1aed791)</span></li>
<li>kdecore/date/kcalendarsystemcoptic.cpp <span style="color: grey">(0a95dbe)</span></li>
<li>kdecore/date/kcalendarsystemcoptic_p.h <span style="color: grey">(5287271)</span></li>
<li>kdecore/date/kcalendarsystemcopticprivate_p.h <span style="color: grey">(35907ff)</span></li>
<li>kdecore/date/kcalendarsystemethiopian.cpp <span style="color: grey">(e2d293f)</span></li>
<li>kdecore/date/kcalendarsystemethiopian_p.h <span style="color: grey">(4f8119e)</span></li>
<li>kdecore/date/kcalendarsystemgregorian.cpp <span style="color: grey">(40db17a)</span></li>
<li>kdecore/date/kcalendarsystemgregorian_p.h <span style="color: grey">(6ba9088)</span></li>
<li>kdecore/date/kcalendarsystemgregorianprivate_p.h <span style="color: grey">(fb7a0dd)</span></li>
<li>kdecore/date/kcalendarsystemhebrew.cpp <span style="color: grey">(e3d1484)</span></li>
<li>kdecore/date/kcalendarsystemhebrew_p.h <span style="color: grey">(75a6280)</span></li>
<li>kdecore/date/kcalendarsystemindiannational.cpp <span style="color: grey">(7222722)</span></li>
<li>kdecore/date/kcalendarsystemindiannational_p.h <span style="color: grey">(499d2fa)</span></li>
<li>kdecore/date/kcalendarsystemislamiccivil.cpp <span style="color: grey">(eea98e2)</span></li>
<li>kdecore/date/kcalendarsystemislamiccivil_p.h <span style="color: grey">(6d4682f)</span></li>
<li>kdecore/date/kcalendarsystemjalali.cpp <span style="color: grey">(889a060)</span></li>
<li>kdecore/date/kcalendarsystemjalali_p.h <span style="color: grey">(c88d304)</span></li>
<li>kdecore/date/kcalendarsystemjapanese.cpp <span style="color: grey">(dbbf94b)</span></li>
<li>kdecore/date/kcalendarsystemjapanese_p.h <span style="color: grey">(09bb4f4)</span></li>
<li>kdecore/date/kcalendarsystemjulian.cpp <span style="color: grey">(9bfc5f9)</span></li>
<li>kdecore/date/kcalendarsystemjulian_p.h <span style="color: grey">(5940c27)</span></li>
<li>kdecore/date/kcalendarsystemminguo.cpp <span style="color: grey">(6761f63)</span></li>
<li>kdecore/date/kcalendarsystemminguo_p.h <span style="color: grey">(0a3b5d7)</span></li>
<li>kdecore/date/kcalendarsystemprivate_p.h <span style="color: grey">(d935ead)</span></li>
<li>kdecore/date/kcalendarsystemqdate.cpp <span style="color: grey">(f233d219)</span></li>
<li>kdecore/date/kcalendarsystemqdate_p.h <span style="color: grey">(9363fff)</span></li>
<li>kdecore/date/kcalendarsystemweek.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kdecore/tests/kcalendartest.h <span style="color: grey">(505c137)</span></li>
<li>kdecore/tests/kcalendartest.cpp <span style="color: grey">(85d790d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107696/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>