<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106987/">http://git.reviewboard.kde.org/r/106987/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Jon Severinsson.</div>
<p style="color: grey;"><i>Updated Nov. 23, 2012, 10:49 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updated patch to make Phonon optional, as per Stephen Kelly's suggestion
[ https://mail.kde.org/pipermail/kde-frameworks-devel/2012-November/001223.html ].</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove KDE_NO_PHONON hackery</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> Previously the Phonon headers and library was always required to build,
but when building with Qt5 the build system made sure never to link
against the library. Thus the build would work (with some missing
features) even if the only available phonon was built with Qt4. (Which
was the only possibility, as Phonon previously didn't build with Qt5).
With this patch, the Phonon headers and library is optional to build,
but if they are found they will be used. Thus building with Qt5 and a
Phonon built with Qt4 will no longer work. However, this patch allows
building with Phonon on Qt5, provided Phonon was built with Qt5.
In other words, these combinations are now supported (* are new with this patch):
Qt4, No Phonon*
Qt4, Phonon 4 on Qt4
Qt4, Phonon 5 on Qt4
Qt5, No Phonon*
Qt5, Phonon 5 on Qt5*
While these combinations are not supported (* previously (sort of) worked):
Qt4, Phonon 4 on Qt5
Qt4, Phonon 5 on Qt5
Qt5, Phonon 4 on Qt4*
Qt5, Phonon 5 on Qt4*
Qt5, Phonon 4 on Qt5
Please note that Phonon 5 requires the patch from review 106970 to
build on Qt5, and that "Qt5, Phonon 4 on Qt5" is fine as far as kdelibs
is concerned, but Phonon 4 won't actually build on Qt5.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(af6c3ec)</span></li>
<li>cmake/modules/FindKDE4Internal.cmake <span style="color: grey">(f99aaee)</span></li>
<li>interfaces/CMakeLists.txt <span style="color: grey">(d496d01)</span></li>
<li>interfaces/kmediaplayer/CMakeLists.txt <span style="color: grey">(4413131)</span></li>
<li>khtml/CMakeLists.txt <span style="color: grey">(db08b27)</span></li>
<li>knotify/config/CMakeLists.txt <span style="color: grey">(ae0933d)</span></li>
<li>knotify/config/knotifyconfigactionswidget.cpp <span style="color: grey">(de892fe)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106987/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>