<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106970/">http://git.reviewboard.kde.org/r/106970/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Phonon.</div>
<div>By Jon Severinsson.</div>
<p style="color: grey;"><i>Updated Nov. 3, 2012, 8:26 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a massive update to the patch. While the old patch just tried to get Qt5 working, the new one tries to fully port Phonon five to ECM. In writing this, I primarily used the frameworks in kdelibs/tier1 and kdelibs/tier2 as examples, trying to make phonon look as much like them as possible.
As this patch now uses the installation paths from the KDEInstallDirs ECM module, it supersedes my older patch "When building Phonon five against Qt5, use qmake to detect Qt installation paths".
As I don't quite understand parts of this (I just banged on the keyboard until they worked), I would *love* if some ECM experts would take a look and tell me what I did wrong. ;-)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is required for the build system to work with both Qt4 and Qt5.
Also do a complete overhaul of the build system, in order to look and
behave more like a regular KF5 tier 1 framework, and less like a
bastard child of Qt.
On Qt4 the build system will now insist on "libinqt5" being installed,
which is located in the kdelibs repository in the frameworks branch.
There is, however, no dependancy on the actual KDE Frameworks 5, and
libinqt5 can be build and installed standalone.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/FindQt4.cmake <span style="color: grey">(75aa34c)</span></li>
<li>abi-check-install.sh.cmake <span style="color: grey">(4296976)</span></li>
<li>cmake/CMakeLists.txt <span style="color: grey">(7574b42)</span></li>
<li>cmake/FindPackageHandleStandardArgs.cmake <span style="color: grey">(7f122ed)</span></li>
<li>cmake/FindPhononInternal.cmake <span style="color: grey">(ae996b9)</span></li>
<li>CTestConfig.cmake <span style="color: grey">(04f21dc)</span></li>
<li>PhononConfig.cmake.in <span style="color: grey">(c6f5eb9)</span></li>
<li>PhononConfigVersion.cmake.in <span style="color: grey">(3ee860b)</span></li>
<li>CMakeLists.txt <span style="color: grey">(ed09836)</span></li>
<li>cmake/MacroEnsureVersion.cmake <span style="color: grey">(6797e5b)</span></li>
<li>cmake/MacroPushRequiredVars.cmake <span style="color: grey">(650b566)</span></li>
<li>cmake/PhononMacros.cmake <span style="color: grey">(2158058)</span></li>
<li>cmake/Qt4ConfigDependentSettings.cmake <span style="color: grey">(b5462e7)</span></li>
<li>cmake/Qt4Macros.cmake <span style="color: grey">(1422c59)</span></li>
<li>cmake/cmake_uninstall.cmake.in <span style="color: grey">(7e36ed4)</span></li>
<li>declarative/CMakeLists.txt <span style="color: grey">(10ea4ad)</span></li>
<li>declarative/qml/CMakeLists.txt <span style="color: grey">(2753842)</span></li>
<li>demos/CMakeLists.txt <span style="color: grey">(4ef9e58)</span></li>
<li>demos/cmake/FindPhonon.cmake <span style="color: grey">(6b608b1)</span></li>
<li>demos/metadatareader/CMakeLists.txt <span style="color: grey">(397c1d6)</span></li>
<li>demos/phota/CMakeLists.txt <span style="color: grey">(09594d7)</span></li>
<li>demos/simplecapture/CMakeLists.txt <span style="color: grey">(28b9564)</span></li>
<li>demos/simpleplayer/CMakeLists.txt <span style="color: grey">(c60ddc9)</span></li>
<li>designer/CMakeLists.txt <span style="color: grey">(e4bb64d)</span></li>
<li>doc/CMakeLists.txt <span style="color: grey">(4e4d86b)</span></li>
<li>doc/Doxyfile.cmake.in <span style="color: grey">(faaa943)</span></li>
<li>lib-descriptor.xml.cmake <span style="color: grey">(9228a39)</span></li>
<li>phonon.pc.cmake <span style="color: grey">(9c64cfc)</span></li>
<li>phonon/CMakeLists.txt <span style="color: grey">(21a9f0d)</span></li>
<li>phonon/phononnamespace.h.in <span style="color: grey">(999ec17)</span></li>
<li>qt_phonon.pri <span style="color: grey">(daf824f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106970/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>