<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105862/">http://git.reviewboard.kde.org/r/105862/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By George Goldberg.</div>
<p style="color: grey;"><i>Updated Aug. 5, 2012, 9:28 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If it works, ship it :)
Thanks for your attempts at building invididual frameworks standalone.
This particular issue is probably a side effect of moving QtMimeTypes into libinqt5, it was separate initially.
(Maybe an option would be to only consider this with a Qt5 build though, then libinqt5 isn't needed at all. I want to keep Qt4 compat for the current work of moving stuff around and cutting internal dependencies, but for building the frameworks standalone, maybe we can say only qt5 is supported... well, unless you'd rather work on this with qt4.)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I hope this is the correct fix - it makes it possible to include files from QtMimeTypes after it has been installed when building individual frameworks standalone, and the includes are still in include/inqt5/QtMimeTypes so I don't think there's any new risk of conflict with Qt upstream instroduced. Is this OK?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libinqt5/src/libqtmimetypes/CMakeLists.txt <span style="color: grey">(80b48879d1b52bee02acbdae7bee22b82cb68940)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105862/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>