<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105868/">http://git.reviewboard.kde.org/r/105868/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah, yes, this is a porting error. KDE4 cmake stuff used to define Q_WS_* cmake variables, but nothing does that in KF5.
I trust you that "WIN32" and "APPLE" are right here, no experience with that.
However this should be fixed across the board, not just in kidletime:
kdecore/CMakeLists.txt:if (NOT Q_OS_X11) // LOL that's a good one :-)
kded/CMakeLists.txt:if (Q_OS_MAC)
kded/CMakeLists.txt:endif (Q_OS_MAC)
kdeui/CMakeLists.txt:if (Q_OS_MAC AND MAC_USE_OSXKEYCHAIN)
kdeui/CMakeLists.txt:else(Q_OS_MAC AND MAC_USE_OSXKEYCHAIN)
kdeui/CMakeLists.txt:else(Q_OS_MAC AND MAC_USE_OSXKEYCHAIN)
kdeui/CMakeLists.txt:endif(Q_OS_MAC AND MAC_USE_OSXKEYCHAIN)
kdeui/CMakeLists.txt:if (Q_OS_MAC)
kdeui/CMakeLists.txt:endif (Q_OS_MAC)
kdeui/CMakeLists.txt:if (Q_OS_WIN)
kdeui/CMakeLists.txt:endif (Q_OS_WIN)
kdeui/CMakeLists.txt:if(Q_OS_MAC)
kdeui/CMakeLists.txt:endif(Q_OS_MAC)
kdeui/CMakeLists.txt:if (Q_OS_MAC)
kdeui/CMakeLists.txt:elseif (Q_OS_WIN)
kdeui/CMakeLists.txt:else(Q_OS_WIN)
kdeui/CMakeLists.txt:endif (Q_OS_MAC)
kdeui/CMakeLists.txt:if (Q_OS_MAC)
kdeui/CMakeLists.txt:endif (Q_OS_MAC)
kinit/CMakeLists.txt:if (Q_OS_MAC)
kinit/CMakeLists.txt:else (Q_OS_MAC)
kinit/CMakeLists.txt:endif (Q_OS_MAC)
tier1/kidletime/src/CMakeLists.txt:elseif (Q_OS_MAC)
tier1/kidletime/src/CMakeLists.txt:elseif (Q_OS_WIN)
tier1/kwindowsystem/src/CMakeLists.txt:if (Q_OS_MAC)
tier1/kwindowsystem/src/CMakeLists.txt:if (Q_OS_WIN)</pre>
<br />
<p>- David</p>
<br />
<p>On August 4th, 2012, 9:57 p.m., Andrius da Costa Ribas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and kdewin.</div>
<div>By Andrius da Costa Ribas.</div>
<p style="color: grey;"><i>Updated Aug. 4, 2012, 9:57 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Q_OS_WIN & Q_OS_MAC not defined at that point, replacing with WIN32 and APPLE.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Got undefined references before the fix.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/kidletime/src/CMakeLists.txt <span style="color: grey">(973d623)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105868/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>