D17816: Support for xattrs on kio copy/move

[Kamil Dudka]

kdudka added a comment.


  Even after applying the proposed patch, the code still looks problematic to me.  I would prefer to have it explained first.  When fgetxattr(..., 0) returns -1/ERANGE, what is the point of calling fgetxattr(..., 0) again?  It is still going to busy-loop indefinitely in this case, doesn't it?  How many times do we actually need to call fgetxattr() on a single file descriptor?  Twice?  Then unbounded loop is not the best construction to begin with.

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: kdudka, usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20210302/645598d7/attachment.htm>