D22764: Stabilize test KFileWidgetTest::testDropFile
David Faure
noreply at phabricator.kde.org
Sun Oct 18 22:28:32 BST 2020
dfaure added inline comments.
INLINE COMMENTS
> kfilewidgettest.cpp:481
> + KDirLister *dirLister = fileWidget.dirOperator()->dirLister();
> + QSignalSpy spy(dirLister, SIGNAL(completed(const QUrl &_url)));
> +
For the record, this is broken, it should have been `completed(QUrl)`. Specifying argument names is incorrect in SIGNAL() and SLOT() macros.
It makes the wait() below fail every time, but after 5s, so the 100ms became 5s :-)
I'm working on fixing this.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D22764
To: meven, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20201018/852d980c/attachment-0001.htm>
More information about the Kde-frameworks-devel
mailing list