D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kconfigloader.cpp:87
> +
> +    if (reader.isEndDocument())
> +        return false;

This logic is inverted., no? We should be at token document end when reader.atEnd() turns true. In any case on successful parse this condition is met here and false returned.

No caller seems to check the return value of ConfigLoaderHandler::parse(), thus nobody noticed?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26890

To: mlaurent, dfaure, apol
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20201102/11d0309c/attachment.htm>