D29397: KPreviewJob : Support for DeviceRatioPixel

[Nathaniel Graham]

ngraham added a comment.


  Overall seems sane. Two questions though:

INLINE COMMENTS

> previewjob.cpp:401
> +        thumbPath = thumbRoot + QLatin1String(cacheWidth == 128 ? "normal" : "large");
> +        thumbPath.append(qFuzzyCompare(devicePixelRatio, 2) ? QStringLiteral("@2x/") : QStringLiteral("/"));
> +

Is this @2x suffix standardized? What happens if I'm using 125% scaling, generate some previews, and then switch back to 100% (no scaling?)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks, ngraham
Cc: elvisangelaccio, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200524/3ad045b3/attachment-0001.htm>