D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Fri May 15 18:09:05 BST 2020


kossebau added inline comments.

INLINE COMMENTS

> openurljob.h:119
> +     * a different implementation on Windows.
> +     *
> +     * @param b whether to only show the "open with" dialog.

Please mention explicit what the default is (false),  to remove any ambiguity.

Some other setters might want to have this stated as well, btw.

REPOSITORY
  R241 KIO

BRANCH
  2020_05_displayOpenWithDialog

REVISION DETAIL
  https://phabricator.kde.org/D29558

To: dfaure, ahmadsamir, broulik, svuorela
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200515/dbdce61d/attachment.htm>


More information about the Kde-frameworks-devel mailing list