D29767: CopyJob: Check if destination dir is a symlink

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thanks for the quick fix and for the test! Just minor issues in comments, feel free to push after fixing.

INLINE COMMENTS

> jobtest.cpp:626
> +    // just the same as copyDirectoryToSamePartition, but this time dest is a symlink.
> +    // So we get a file in the symblink dir, "dirFromHome_symlink/dirFromHome" and
> +    // "dirFromHome_symOrigin/dirFromHome"

Typo: symblink

> jobtest.cpp:633
> +    createTestDirectory(origSymlink);
> +    //createTestSymlink(origSymlink, targetSymlink.toLatin1());
> +

remove

> jobtest.cpp:648
> +
> +    // file is visible in both symlinks ends
> +    QVERIFY(QFileInfo(origSymlink + "/dirFromHome").isDir());;

there is only one symlink ;-)

Maybe "The file is visible in both places, due to the symlink" ?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29767

To: meven, #frameworks, dfaure, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200515/7335c709/attachment.htm>